feat(providers): allow for interpolation of hostnames for dayforce#5539
Open
hassan254-prog wants to merge 5 commits intomasterfrom
Open
feat(providers): allow for interpolation of hostnames for dayforce#5539hassan254-prog wants to merge 5 commits intomasterfrom
hassan254-prog wants to merge 5 commits intomasterfrom
Conversation
hassan254-prog
force-pushed
the
wari/add-support-for-dayforce-test
branch
from
abf790b to
87238ec
Compare
![propel-code-bot[bot]](https://avatars.githubusercontent.com/in/1179004?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
There was a problem hiding this comment.
No issues found; changes look consistent with the stated goals.
Status: No Issues Found | Risk: Low
Review Details
📁 21 files reviewed | 💬 0 comments
Instruction Files
├── .claude/
│ ├── agents/
│ │ └── nango-docs-migrator.md
│ └── skills/
│ ├── agent-builder-skill/
│ │ ├── EXAMPLES.md
│ │ └── SKILL.md
│ ├── creating-integration-docs/
│ │ └── SKILL.md
│ └── creating-skills-skill/
│ └── SKILL.md
├── AGENTS.md
└── GEMINI.md
TBonnin
reviewed
Mar 4, 2026
|
|
||
| export function makeUrl(template: string, config: Record<string, any>, skipEncodeKeys: string[] = []): URL { | ||
| const cleanTemplate = template.replace(/connectionConfig\./g, ''); | ||
| const cleanTemplate = template.replace(/connectionConfig\./g, '').replace(/credentials\./g, ''); |
Collaborator
There was a problem hiding this comment.
is it a breaking change? is makeUrl ever called elsewhere?
| const urlWithConnectionConfig = | ||
| typeof tokenUrl === 'string' | ||
| ? makeUrl(tokenUrl, { ...connectionConfig, ...dynamicCredentials }).toString() | ||
| : interpolateString(interpolateString('', connectionConfig), dynamicCredentials); |
Collaborator
There was a problem hiding this comment.
wouldn't this line always evaluate to '', making new URL('') throw?
| type: string | ||
| title: Company ID | ||
| order: 1 | ||
| order: 3 |
Collaborator
There was a problem hiding this comment.
should the company ID which is required stay above the optional params below?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the problem and your solution
Add Dayforce hostname interpolation and update auth URL handling
This PR adds configurable hostname interpolation for Dayforce by updating provider configuration, token URL construction, and documentation to support optional client and identity hostnames for non-production environments. It also refactors token URL building to use
makeUrlwith merged connection config and credentials, expanding URL interpolation behavior to stripcredentials.prefixes and adding a corresponding unit test.Key Changes
• Updated Dayforce
proxy.base_urlandtoken_urlinpackages/providers/providers.yamlto support host interpolation with fallbacks and added optionalclientHostnameandidentityHostnamefields• Refactored token URL construction in
packages/shared/lib/services/connection.service.tsto usemakeUrland expandedmakeUrlinpackages/shared/lib/utils/utils.tsto stripcredentials.prefixes• Added Dayforce quickstart and connection guide updates in
docs/api-integrations/dayforce.mdxanddocs/api-integrations/dayforce/connect.mdx, plus navigation adjustments indocs/docs.jsonand related doc snippetsPossible Issues
• Navigation moved from
/integrations/all/dayforceto/api-integrations/dayforcewithout a redirect entry indocs/docs.json(per review comment) may break existing links.This summary was automatically generated by @propel-code-bot