feat(docker): add multi-arch builds for amd64 and arm64#5577
Open
alexkreidler wants to merge 2 commits intoNangoHQ:masterfrom
Open
feat(docker): add multi-arch builds for amd64 and arm64#5577alexkreidler wants to merge 2 commits intoNangoHQ:masterfrom
alexkreidler wants to merge 2 commits intoNangoHQ:masterfrom
Conversation
Build and push multi-platform Docker images (linux/amd64 + linux/arm64) so the images work natively on ARM hosts like Apple Silicon Macs. - Build scripts use multi-platform when pushing to registry - Local builds stay single-platform (buildx type=docker limitation) - Remove hardcoded platform: linux/amd64 from docker-compose.yaml Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
No issues found; multi-arch build updates look sound and ready.
Status: No Issues Found | Risk: Low
Review Details
📁 4 files reviewed | 💬 0 comments
Instruction Files
├── .claude/
│ ├── agents/
│ │ └── nango-docs-migrator.md
│ └── skills/
│ ├── agent-builder-skill/
│ │ ├── EXAMPLES.md
│ │ └── SKILL.md
│ ├── creating-integration-docs/
│ │ └── SKILL.md
│ └── creating-skills-skill/
│ └── SKILL.md
├── AGENTS.md
└── GEMINI.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
linux/amd64+linux/arm64) so images work natively on ARM hosts (e.g. Apple Silicon Macs)buildx type=dockerlimitation; multi-arch only applies when pushing to registryplatform: linux/amd64fromdocker-compose.yamlCloses #5576 and closes NAN-4926
Changes
scripts/build_docker.sh—pushaction now buildslinux/amd64,linux/arm64viatype=registryscripts/build_docker_self_hosted.sh— restructured to build+push multi-arch in one step whenPUSH=true.github/workflows/build-image.yaml— split build step so authenticated builds usepush(multi-arch)docker-compose.yaml— removedplatform: linux/amd64from nango-serverTest plan
buildaction succeeds (amd64,type=docker)🤖 Generated with Claude Code
This PR updates Docker build scripts and CI to produce multi-architecture images for
linux/amd64andlinux/arm64when pushing to a registry, while keeping local builds single-arch due tobuildxoutput constraints. It also removes the hardcoded platform override fromdocker-compose.yamlso the hosted image can run natively on ARM hosts.Possible Issues
• If
PUSHis not passed astrue,scripts/build_docker_self_hosted.shwill default to amd64-only builds, which may surprise callers expecting multi-arch.• CI multi-arch builds require
buildxand registry auth; failures will now block multi-arch push paths.This summary was automatically generated by @propel-code-bot