Skip to content

Fix thread-safety bug in geom.c #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oskooi wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −3
Open

Fix thread-safety bug in geom.c #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions utils/geom.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1007,8 +1007,6 @@ static number compute_dot_cross(vector3 a, vector3 b, vector3 c) {
Requires that geometry_lattice global has been initialized,
etcetera. */
void geom_get_bounding_box(geometric_object o, geom_box *box) {
geom_fix_object_ptr(&o);

/* initialize to empty box at the center of the object: */
box->low = box->high = o.center;

Expand Down Expand Up @@ -2222,7 +2220,8 @@ int intersect_line_with_prism(prism *prsm, vector3 pc, vector3 dc, double *slist
/***************************************************************/
/***************************************************************/
double intersect_line_segment_with_prism(prism *prsm, vector3 pc, vector3 dc, double a, double b) {
double *slist = prsm->workspace.items;
int num_vertices = prsm->vertices_p.num_items;
double slist[num_vertices + 2];
int num_intersections = intersect_line_with_prism(prsm, pc, dc, slist);

// na=smallest index such that slist[na] > a
Expand Down