Add multi-architecture support (amd64 + arm64) #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refine Docker image tag logic in manual installer workflow
This enables building Docker images for both linux/amd64 and linux/arm64 platforms, addressing the need for ARM64 support. Changes: - Dockerfile: Use TARGETARCH to dynamically select the correct OpenStudio package (x86_64 or arm64) based on the target platform - CI workflow: Add QEMU and Docker Buildx setup for cross-platform builds - deploy_docker.sh: Use `docker buildx build --push` with multi-platform support instead of separate tag/push commands This is possible because OpenStudio now provides ARM64 builds for Ubuntu (available since v3.8.0). Closes NatLabRockies#85 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for building multi-architecture Docker images (linux/amd64 and linux/arm64), addressing the request in #85.
Changes
TARGETARCHbuild arg (automatically set by Docker buildx) to dynamically select the correct OpenStudio package based on target platformdocker tag+docker pushwithdocker buildx build --push --platform=linux/amd64,linux/arm64(required for multi-platform manifests)Why this works now
OpenStudio has been providing ARM64 builds for Ubuntu since v3.8.0:
OpenStudio-X.X.X-Ubuntu-24.04-arm64.debOpenStudio-X.X.X-Ubuntu-24.04-x86_64.debTesting
The existing test suite runs on amd64 (CI runners). The ARM64 build uses the same Dockerfile with TARGETARCH selecting the appropriate package.