Skip to content

fix(ios): cleaning firebase-core iOS build warnings #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
triniwiz merged 1 commit into from
Apr 3, 2024
Merged

fix(ios): cleaning firebase-core iOS build warnings #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/firebase-core/platforms/ios/src/TNSFirebaseCore.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#import <Foundation/Foundation.h>
#import "UIApplicationDelegate+LaunchExtension.h"
typedef void(^LaunchCallback)();
typedef void(^LaunchCallback)(void);
@interface TNSFirebaseCore: NSObject
+(LaunchCallback) onAppFinishLaunchingCallback;
+(void) setOnAppFinishLaunchingCallback:(LaunchCallback)callback;
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase-core/platforms/ios/src/UIApplicationDelegate+LaunchExtension.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#import <UIKit/UIKit.h>

@interface NSObject (TNSUIAppDelegateExt) <UIApplicationDelegate>
- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(nullable NSDictionary<UIApplicationLaunchOptionsKey, id> *)launchOptions;
- (BOOL)application:(nullable UIApplication *)application didFinishLaunchingWithOptions:(nullable NSDictionary<UIApplicationLaunchOptionsKey, id> *)launchOptions;
@end
2 changes: 1 addition & 1 deletion packages/firebase-core/platforms/ios/src/UIApplicationDelegate+LaunchExtension.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#import <objc/runtime.h>

@implementation NSObject (TNSUIAppDelegateExt)
- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(nullable NSDictionary<UIApplicationLaunchOptionsKey, id> *)launchOptions {
- (BOOL)application:(nullable UIApplication *)application didFinishLaunchingWithOptions:(nullable NSDictionary<UIApplicationLaunchOptionsKey, id> *)launchOptions {
LaunchCallback callback = [TNSFirebaseCore onAppFinishLaunchingCallback];
if(callback != nil){
callback();
Expand Down