fix(google-cloud): format_affected_user/1 with non-binary values#161
Merged
AndrewDryga merged 3 commits intoNebo15:masterfrom Jul 8, 2025
Merged
Conversation
raulpe7eira
changed the title
format-affected-user/1 with non-binary values
raulpe7eira
changed the title
format-affected-user/1 with non-binary valuesformat_affected_user/1 with non-binary values
AndrewDryga
reviewed
Jul 7, 2025
Member
|
Thank you! I left one small comment and LGTM |
|
@AndrewDryga Hi, can you release a new version? |
Member
|
@georgeguimaraes Sure, I just pushed it. Sorry for the long wait. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐞 Problem
The
google_cloudformatter crashes when it receives a crash log where theuser contextcontains values that are not binaries (e.g., integers). This happens because the formatter uses the<>operator for string concatenation, which raises an error when used with non-binary types.Truncated example of a crashed log:
2025-01-01T01:01:01.000000+00:00 error: FORMATTER CRASH: {string,<<"** (Postgrex.Error) ERROR 428...✅ Solution
This PR replaces the use of the
<>operator withEnum.join/2when formatting key-value pairs. This approach safely converts all values to strings before concatenation, preventing crashes when values are not binaries.