Skip to content

Remove unused _is_known_via_attributes#2240

Merged
fingolfin merged 1 commit intomasterfrom
mh/_is_known_via_attributes
Dec 12, 2025
Merged

Remove unused _is_known_via_attributes#2240
fingolfin merged 1 commit intomasterfrom
mh/_is_known_via_attributes

Conversation

@fingolfin
Copy link
Copy Markdown
Member

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.01%. Comparing base (bee81db) to head (8a34fe0).
⚠️ Report is 46 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2240   +/-   ##
=======================================
  Coverage   88.00%   88.01%           
=======================================
  Files         127      126    -1     
  Lines       31803    31800    -3     
=======================================
  Hits        27989    27989           
+ Misses       3814     3811    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thofma
Copy link
Copy Markdown
Member

thofma commented Dec 11, 2025

Maybe in Oscar? Or maybe the plan was to use this in Oscar?

@fingolfin
Copy link
Copy Markdown
Member Author

It is not used in any of our packages (I grepped for it), and as I recall it was meant as a kind of "demo" of what is possible but in the end we cut all uses of it, yet forgot to remove it itself.

Alas @HechtiDerLachs should comment as well

@HechtiDerLachs
Copy link
Copy Markdown
Contributor

I'm fine with removing this. If one wanted to have this again, one can implement this for their custom types. But this generic fallback is not really needed. It must have been a demo at some point.

@fingolfin fingolfin merged commit f37df53 into master Dec 12, 2025
23 checks passed
@fingolfin fingolfin deleted the mh/_is_known_via_attributes branch December 12, 2025 18:07
@lgoettgens lgoettgens added the release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes label Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants