Skip to content

Allow fraction coercion to residue rings#2245

Merged
fingolfin merged 2 commits intoNemocas:masterfrom
SoongNoonien:residue_coerce
Dec 12, 2025
Merged

Allow fraction coercion to residue rings#2245
fingolfin merged 2 commits intoNemocas:masterfrom
SoongNoonien:residue_coerce

Conversation

@SoongNoonien
Copy link
Copy Markdown
Collaborator

I think this should be there alongside the other coercions we support already.


@test isa(d, EuclideanRingResidueRingElem)

@test R(2//3) * R(3) == R(2)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I note that this also works in Oscar:

julia> F = GF(5);

julia> F(2//3)
4

And of course GAP also supports all that, so this change is fine from my side... But let's see if @thofma or @fieker agree / disagree.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.07%. Comparing base (290941e) to head (eeab579).
⚠️ Report is 41 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2245      +/-   ##
==========================================
+ Coverage   88.00%   88.07%   +0.06%     
==========================================
  Files         127      127              
  Lines       31803    31773      -30     
==========================================
- Hits        27989    27984       -5     
+ Misses       3814     3789      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fieker
Copy link
Copy Markdown
Contributor

fieker commented Dec 12, 2025

as long as this does not automatically involce to allow (2//3) mod 5 I am happy

@fingolfin fingolfin enabled auto-merge (squash) December 12, 2025 13:27
@fingolfin fingolfin disabled auto-merge December 12, 2025 13:28
@fingolfin fingolfin merged commit 2bd78da into Nemocas:master Dec 12, 2025
28 of 31 checks passed
@aaruni96 aaruni96 added enhancement New feature or request release notes: highlight PRs introducing changes that should be highlighted at the top of the release notes release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels Dec 17, 2025
@SoongNoonien SoongNoonien deleted the residue_coerce branch January 7, 2026 13:56
@lgoettgens lgoettgens added release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes and removed release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes release notes: highlight PRs introducing changes that should be highlighted at the top of the release notes labels Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants