Skip to content

add simplfication/ canonicalization to FunctionFields #2393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fieker wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −0
Open

add simplfication/ canonicalization to FunctionFields #2393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/generic/GenericTypes.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1088,6 +1088,11 @@ mutable struct FunctionFieldElem{T <: FieldElement} <: AbstractAlgebra.FieldElem
parent::FunctionField{T}

function FunctionFieldElem{T}(R::FunctionField{T}, num::Poly{S}, den::S) where {T <: FieldElement, S <: PolyRingElem{T}}
if !iszero(num) #normalize the denominator
Copy link
Copy Markdown
Member

@lgoettgens lgoettgens Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only do this if the numerator is not zero? In the case of it being zero, couldn't we canonicalize even more by setting the denominator to 1?

c = inv(content(den))
num *= c
den *= c
Comment on lines +1092 to +1094
Copy link
Copy Markdown
Member

@lgoettgens lgoettgens Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
c = inv(content(den))
num *= c
den *= c
c = content(den)
num = divexact(num, c)
den = divexact(den, c)

A long time ago someone (you) told me that I should not use inv when doing division :)

end
return new{T}(num, den, R)
end
end
Expand Down
Loading