Skip to content

Fix viewmodel disappearing#1424

Merged
Rainyan merged 3 commits intoNeotokyoRebuild:masterfrom
Rainyan:bug/vm-vanish
Nov 20, 2025
Merged

Fix viewmodel disappearing#1424
Rainyan merged 3 commits intoNeotokyoRebuild:masterfrom
Rainyan:bug/vm-vanish

Conversation

@Rainyan
Copy link
Copy Markdown
Member

@Rainyan Rainyan commented Oct 11, 2025

Description

Fix the VM hiding logic to not repeatedly add/remove the nodraw flag, but instead implement the appropriate ShouldDraw override.

Toolchain

  • Windows MSVC VS2022

Linked Issues

Fix NEO guarded var init outside NEO scope & cleanup
@Rainyan Rainyan marked this pull request as ready for review November 17, 2025 21:43
@Rainyan
Copy link
Copy Markdown
Member Author

Rainyan commented Nov 17, 2025

So I don't have any reliable way to reproduce this bug so this is somewhat speculative, but I'm fairly certain it should fix the bug.

What I think was happening is the nodraw flag of the viewmodel going stale for some sequence of events. So I've changed the logic to simply implement the ShouldDraw override on the viewmodel instead of juggling the draw flags.

@Rainyan Rainyan requested a review from a team November 17, 2025 21:44
@Rainyan Rainyan requested a review from a team November 19, 2025 20:01
@Rainyan Rainyan merged commit ffaf03d into NeotokyoRebuild:master Nov 20, 2025
7 checks passed
@Rainyan Rainyan deleted the bug/vm-vanish branch November 20, 2025 13:18
@Agiel Agiel mentioned this pull request Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Viewmodel vanishes after alt tab(?)

3 participants