Skip to content

feat: [taro-webpack5-runner miniplugin]微信小程序tabbar list 中数据类型不匹配时编译时需报错提醒#16225

Open
xujiujiu wants to merge 2 commits intoNervJS:mainfrom
xujiujiu:feat-minitabbar
Open

feat: [taro-webpack5-runner miniplugin]微信小程序tabbar list 中数据类型不匹配时编译时需报错提醒#16225
xujiujiu wants to merge 2 commits intoNervJS:mainfrom
xujiujiu:feat-minitabbar

Conversation

@xujiujiu
Copy link
Contributor

@xujiujiu xujiujiu commented Aug 2, 2024

这个 PR 做了什么? (简要描述所做更改)
编译成小程序时,若tabbar 的list中存在数据类型不匹配的情况,编译时需做报错提醒。当前情况只会报错:Cannot read properties of null (reading 'iconPath')

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

@taro-bot2
Copy link

taro-bot2 bot commented Aug 2, 2024

欢迎提交 PR~ Taro 非常感谢您对开源事业做出的贡献!🌷🌷🌷

一般 PR 会在一到两周内进行 review,成功合入后会随下一个版本进行发布。

Review 需要耗费大量时间,所以请遵循以下规范,协助我们提高 review 效率🙏🙏🙏

  1. 详细介绍 PR 的背景(非常重要,例如解决了什么问题,该问题如何复现等)
  2. 确保 CI 顺利运行。
  3. 最好能提供对应的测试用例。

为了更好地进行沟通,请加入 Taro 开发者微信群:

@codecov
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.50%. Comparing base (6ed8d05) to head (8b51847).
⚠️ Report is 336 commits behind head on main.

❌ Your project check has failed because the head coverage (58.50%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #16225   +/-   ##
=======================================
  Coverage   58.50%   58.50%           
=======================================
  Files         466      466           
  Lines       27107    27107           
  Branches     5946     5954    +8     
=======================================
  Hits        15860    15860           
- Misses       9769     9863   +94     
+ Partials     1478     1384   -94     
Flag Coverage Δ
taro-cli 73.67% <ø> (ø)
taro-runtime 59.87% <ø> (ø)
taro-web 53.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This was referenced Aug 3, 2024
This was referenced Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant