SettingForm 优化 #125
Merged
SettingForm 优化 #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwsun
reviewed
Mar 27, 2024
| onChange: (value: T, detail?: SetterOnChangeDetailType) => void; | ||
| readOnly?: boolean; | ||
| disabled?: boolean; | ||
| toggleIsVariable?: () => void; |
Contributor
There was a problem hiding this comment.
和 disableVariableSetter 区别是啥？
Contributor
There was a problem hiding this comment.
这部分逻辑已经提供了支持，无需增加 toggleIsVariable 的逻辑。先拿掉吧。其他都没啥问题。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.