Skip to content

Ensure the generated package is a valid PowerPoint Addin file#42

Merged
jozefizso merged 2 commits intomainfrom
feature/40-add-integration-test-to-validate-generated-powerpoint-addin
Jan 12, 2026
Merged

Ensure the generated package is a valid PowerPoint Addin file#42
jozefizso merged 2 commits intomainfrom
feature/40-add-integration-test-to-validate-generated-powerpoint-addin

Conversation

@jozefizso
Copy link
Member

Implements #40.

@jozefizso jozefizso added this to the v2 milestone Jan 12, 2026
@jozefizso jozefizso self-assigned this Jan 12, 2026
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a3d89068e5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

The CompilePowerPointFile helper was using the CompileVbaProject(Stream)
overload which leaves the stream position at the end after writing. This
caused CompilePowerPointMacroFile to feed zero bytes to VbaProjectPart,
resulting in empty VBA content in generated add-ins.

Changed to use the parameterless CompileVbaProject() overload which
returns a MemoryStream with position already reset to 0, ensuring the
full VBA project content is properly embedded.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@jozefizso jozefizso merged commit d1f2ef2 into main Jan 12, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add integration test to validate generated PowerPoint add-in package structure

3 participants