remove obsolete crypt.h header inclusion

[rdmark]

libcrypt is a 25 year old dependency that is long since obsolete, so sign that any symbols from this library is required anymore (supplanted by libgcrypt)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

🔥 Spectest (AFP 3.4) - Flamegraph (AFP_ASSERT active)

Commit: c28f643cbedd83115c65ca7fdbdb7bac6b3a0e0e
Profiling: On-CPU sampling @ 1009 Hz (prime), DWARF call-graph, x86_64
Build: debugoptimized (-O2 -g -fno-omit-frame-pointer)
Total Runtime: 66s, Netatalk Code-time: 4.2%,
Stacks: 1957, SVG size: 1.2M

🔥 Open interactive Flamegraph (SVG)

📥 Download from artifacts →

🔝 Top 10 leaf functions

Function	Samples
finish_task_switch.isra.0	550049400
do_syscall_64	419226840
_raw_spin_unlock_irqrestore	274529160
__cp_end	172447920
srso_alias_safe_ret	84241800
x64_sys_call	43607520
__syscall_cp_c	35678880
dircache_process_deferred_chain	31714560
find_get_block_common	27750240
schedule	22794840

[augmentcode]

🤖 Augment PR Summary

Summary: Removes the crypt.h header check and the conditional <crypt.h> includes from the passwd-based UAM modules.
Why: Aims to eliminate an obsolete libcrypt header dependency now that other auth paths rely on libgcrypt/platform mechanisms.

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. 1 suggestion posted.

Comment augment review to trigger a new review at any time.

[augmentcode]

crypt()/crypt_checkpass() are used later in this file; removing <crypt.h> can leave them without a prototype on platforms where they aren’t declared via other headers, causing implicit declarations / wrong return types. This is likely to become a hard build failure under C99/-Werror or lead to runtime issues on 64-bit.

Severity: high

Other Locations

• etc/uams/uams_dhx_passwd.c:22
• etc/uams/uams_dhx2_passwd.c:24

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

[rdmark]

I was wrong, libcrypt provides f.e. crypt_checkpass