[playground] fix compile hotkey combo adds extra symbol to the code#539
Merged
[playground] fix compile hotkey combo adds extra symbol to the code#539
Conversation
Rolaman
approved these changes
Mar 12, 2025
ukorvl
force-pushed
the
fix-compile-btn-adds-a-symbol
branch
from
101076b to
b6e88e0
Compare
ukorvl
force-pushed
the
fix-compile-btn-adds-a-symbol
branch
from
b6e88e0 to
427f1ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #167
As described in the #167, currently we have a problem with compile hotkey (
meta+enterorcmd+enter) when user focuses code field.This diff adds keymap extension that allows to define custom keyboard shortcuts (key bindings). By setting
run: () => true,we prevent any action on the code field. At the same time we runcompile()event avoiding adding extra symbols to the code.We need to use
Prec.highest()because the extension should always go first in the extensions list.