Sync Committee: Initial Batch Construction#600
Merged
Conversation
akokoshn
reviewed
Mar 19, 2025
009f059 to
35b3f85
Compare
35b3f85 to
b961636
Compare
b961636 to
b1c1d45
Compare
To align with state root initialization on the `Proposer` side, the latest proved state root (or genesis block) is used as a starting point in the Aggregator as well. * Implemented the `getStartingBlockRef()` method, which retrieves the starting point for the next fetching iteration, prioritizing the latest fetched block if available; * If neither `LatestFetched` nor `LatestProvedStateRoot` is defined, the method returns `ErrStateRootNotInitialized`; * Added a check to verify whether the `LatestFetched` block exists on L2, triggering a reset if it does not (`requireBlockExistsInChain`); In short, `LatestProvedStateRoot` must now be initialized to be used by `Aggregator` as the starting point for block processing
b1c1d45 to
13377a2
Compare
akokoshn
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync Committee: Initial Batch Construction
To align with state root initialization on the
Proposerside, the latest proved state root (or genesis block) is used as a starting point in the Aggregator as well.getStartingBlockRef()method, which retrieves the starting point for the next fetching iteration, prioritizing the latest fetched block if available;LatestFetchednorLatestProvedStateRootis defined, the method returnsErrStateRootNotInitialized;LatestFetchedblock exists on L2, triggering a reset if it does not (requireBlockExistsInChain);In short,
LatestProvedStateRootmust now be initialized to be used byAggregatoras the starting point for block processing