Conversation
ukorvl
force-pushed
the
fix-publish-npm-script
branch
from
bb95252 to
3237f63
Compare
ukorvl
force-pushed
the
fix-publish-npm-script
branch
from
3237f63 to
6d4a180
Compare
ukorvl
force-pushed
the
fix-publish-npm-script
branch
from
6d4a180 to
f716164
Compare
ukorvl
requested review from
0xAleksaOpacic,
Gezort,
Un1oR,
avm and
knazarov
as code owners
KlonD90
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This diff fixes Publish npm packages workflow by adding
publish_npm_packages.shscript.Simply put, the problem that is default npm publish command throws an error if the package is already published. It makes workflow run look incorrect, even if it runs as expected. We don't want to publish always all packages. If it is already published - we just want to ingore it, that's why simple bash wrapper is needed.
All of this were successful runs, which exited with error because of npm. It can make a developer confused.