Add unittests in rollup-bridge-contracts/#635
Merged
AndreyMlashkin merged 2 commits intomainfrom Mar 24, 2025
Merged
Conversation
Contributor
|
Btw, let's squash the commits? From my POV they are not so informative to include into |
AndreyMlashkin
force-pushed
the
add_foundry
branch
from
8a5072a to
19087ba
Compare
AndreyMlashkin
changed the title
AndreyMlashkin
requested review from
akokoshn,
defistar and
knazarov
and removed request for
akokoshn
akokoshn
reviewed
Mar 24, 2025
AndreyMlashkin
force-pushed
the
add_foundry
branch
2 times, most recently
from
4ba41df to
fd13a11
Compare
AndreyMlashkin
force-pushed
the
add_foundry
branch
from
fd13a11 to
26e76a0
Compare
AndreyMlashkin
force-pushed
the
add_foundry
branch
from
26e76a0 to
3e37f07
Compare
akokoshn
reviewed
Mar 24, 2025
| @@ -0,0 +1,19 @@ | |||
| #!/bin/bash | |||
Contributor
Author
There was a problem hiding this comment.
It is for manual unittesting without nix.
If you think, it is not required, I can delete it
AndreyMlashkin
force-pushed
the
add_foundry
branch
from
3e37f07 to
fd64b71
Compare
defistar
approved these changes
Mar 24, 2025
knazarov
reviewed
Mar 24, 2025
knazarov
reviewed
Mar 24, 2025
knazarov
approved these changes
Mar 24, 2025
Contributor
knazarov
left a comment
knazarov
left a comment
There was a problem hiding this comment.
It's fine, except probably for a few nitpicks (see comments).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add forge unittests in rollup-bridge-contracts/