Conversation
explorer_frontend/src/features/transaction-list/components/TransactionList.tsx
Outdated
Show resolved
Hide resolved
explorer_frontend/src/features/transaction-list/components/TransactionList.tsx
Outdated
Show resolved
Hide resolved
|
Hey! Thanks for the contribution. I left some comments. |
|
Hello, I found the sql queries and i have improvcd the sorting within the query, how do you see that? also, getTransactionByHash has limit set to 1, was this intentional? js |
see no problems here, though LIMIT is redundant you are right can you please remove all unnecessary code formatting and (probably) sorting on frontend side? |
|
Hey, @ekumamatthew Thanks for the contribution! According to our contribution guide, PRs should not include merge commits — please use rebase instead of merge to keep the commit history clean. When you get a chance, could you tidy up the commit history to follow the guideline? |
b730b8a to
56960a1
Compare
|
Hey @ekumamatthew — thanks a lot for the contribution! 🙌 Your authorship is fully preserved in the commits — you're still credited as the contributor. Approved ✅ |
I did the chronologic sorting but in the backend I can't find where the event is being indexed, This would have enable me get the timestamps based on the data index. although the timestamps can still be manipulated from the backend, so I did the sorting from the front end
Closes #566