Skip to content

Feat/chronological tx sort#651

Closed
ekumamatthew wants to merge 1 commit intoNilFoundation:mainfrom
ekumamatthew:feat/chronological-tx-sort
Closed

Feat/chronological tx sort#651
ekumamatthew wants to merge 1 commit intoNilFoundation:mainfrom
ekumamatthew:feat/chronological-tx-sort

Conversation

@ekumamatthew
Copy link
Copy Markdown
Contributor

@ekumamatthew ekumamatthew commented Mar 25, 2025

I did the chronologic sorting but in the backend I can't find where the event is being indexed, This would have enable me get the timestamps based on the data index. although the timestamps can still be manipulated from the backend, so I did the sorting from the front end

Closes #566

@ukorvl
Copy link
Copy Markdown
Contributor

ukorvl commented Mar 25, 2025

Hey! Thanks for the contribution. I left some comments.

@ekumamatthew
Copy link
Copy Markdown
Contributor Author

ekumamatthew commented Mar 25, 2025

Hello, I found the sql queries and i have improvcd the sorting within the query, how do you see that?

also,

getTransactionByHash has limit set to 1,

was this intentional?

js
query: SELECT ${fieldsFull} FROM transactions WHERE hash = {hash: String} and outgoing = false LIMIT 1 ,

@ukorvl
Copy link
Copy Markdown
Contributor

ukorvl commented Mar 26, 2025

@ekumamatthew

SELECT ${fieldsFull} FROM transactions WHERE hash = {hash: String} and outgoing = false LIMIT 1

see no problems here, though LIMIT is redundant you are right

can you please remove all unnecessary code formatting and (probably) sorting on frontend side?

@0xAleksaOpacic 0xAleksaOpacic added the ODHack12 Tag for issues which are suitable for ODHack week label Mar 26, 2025
@0xAleksaOpacic
Copy link
Copy Markdown
Contributor

Hey, @ekumamatthew

Thanks for the contribution! According to our contribution guide, PRs should not include merge commits — please use rebase instead of merge to keep the commit history clean.

When you get a chance, could you tidy up the commit history to follow the guideline?

@ekumamatthew ekumamatthew force-pushed the feat/chronological-tx-sort branch from b730b8a to 56960a1 Compare March 27, 2025 09:57
@ukorvl
Copy link
Copy Markdown
Contributor

ukorvl commented Mar 28, 2025

Hey @ekumamatthew — thanks a lot for the contribution! 🙌
We’ve opened a signed version of this PR to comply with our commit policy:
🔗 #687

Your authorship is fully preserved in the commits — you're still credited as the contributor.
Appreciate your work on this, and looking forward to more contributions! 🚀

Approved ✅

@ukorvl ukorvl closed this Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ODHack12 Tag for issues which are suitable for ODHack week

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[explorer] Sort transactions chronologically

3 participants