[consensus] fix IsValidProposalHash function usage#663
Merged
Conversation
olegrok
force-pushed
the
consensus-fix-usage
branch
from
b663b5a to
1bdf9fe
Compare
olegrok
force-pushed
the
consensus-fix-usage
branch
from
6db1dd1 to
e069275
Compare
This function is expected to be quite lightweight because it can be called several times during checking round change certificates. After this patch we will perform only fast checks of proposal.
Some bugs were fixed
… for topic` errors in log Connection manager should also implement Decay interface. Before it didn't. This patch truly extends logic of basic connection manager.
olegrok
force-pushed
the
consensus-fix-usage
branch
from
a7455ae to
9a947ed
Compare
shermike
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function is expected to be quite lightweight because it can be called several times during checking round change certificates. After this patch we will perform only fast checks of proposal.
Closes #666