Skip to content

[playground] remove rpcUrl validation#712

Merged
ukorvl merged 1 commit intomainfrom
remove-builtin-wallet-endpoint-validation
Mar 31, 2025
Merged

[playground] remove rpcUrl validation#712
ukorvl merged 1 commit intomainfrom
remove-builtin-wallet-endpoint-validation

Conversation

@ukorvl
Copy link
Copy Markdown
Contributor

@ukorvl ukorvl commented Mar 31, 2025

This diff contains two changes:

  • Validation of the rpc url is removed. The reason behind that is that validation was too strict and user was not able to develop playground locally.
  • Rpc url is now set only after successful wallet creation. It's kinda obvious - there is no need in rpc url if you don't have a wallet. There was a buggy scenario when user tries to create a wallet with some rpc url, which passed validation, but request is not successful. In that case rpc url is going to be set without wallet creation and user is going to receive message "Something wrong with the network" every time the page is open.

@ukorvl ukorvl added the explorer Related to explorer interface label Mar 31, 2025
@ukorvl ukorvl self-assigned this Mar 31, 2025
@ukorvl ukorvl requested a review from KlonD90 as a code owner March 31, 2025 15:06
@ukorvl ukorvl added playground Related to playground interface and removed explorer Related to explorer interface labels Mar 31, 2025
Copy link
Copy Markdown
Contributor

@KlonD90 KlonD90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ukorvl ukorvl added this pull request to the merge queue Mar 31, 2025
Merged via the queue into main with commit 81db9ce Mar 31, 2025
15 checks passed
@ukorvl ukorvl deleted the remove-builtin-wallet-endpoint-validation branch March 31, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

playground Related to playground interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants