Skip to content

fix: Block Explorer Page Update#762

Merged
idea404 merged 2 commits intoNilFoundation:mainfrom
Abeeujah:fix-issue-625
Apr 24, 2025
Merged

fix: Block Explorer Page Update#762
idea404 merged 2 commits intoNilFoundation:mainfrom
Abeeujah:fix-issue-625

Conversation

@Abeeujah
Copy link
Copy Markdown
Contributor

@Abeeujah Abeeujah commented Apr 5, 2025

Short Summary

Tis PR updates the block explorer page to the latest UI version designed.

What Changes Were Made

  • Fixed the display state for empty transactions
  • Fixed the display state for block info
  • Updated the transactions view state to include <All | Incoming | Outgoing>
  • Added Pagination
  • Updated the table to the new table layout
  • Updated the new resizing logic.

Related Issue

Fixes #625

Screenshots / Visual Changes

localhost_5173_block_1_12375
localhost_5173_block_1_12376
localhost_5173_block_1_12376 (1)
localhost_5173_block_1_12384

Checklist

  • I have read and followed the Contributing Guide
  • I have tested the changes locally
  • I have added relevant tests (if applicable)
  • I have updated documentation/comments (if applicable)

@Abeeujah Abeeujah requested review from KlonD90 and ukorvl as code owners April 5, 2025 18:04
@ukorvl ukorvl added the ODHack12 Tag for issues which are suitable for ODHack week label Apr 7, 2025
@ukorvl
Copy link
Copy Markdown
Contributor

ukorvl commented Apr 21, 2025

Hey! As for pagination - let's use Pagination component from ui-kit for the sake of code minimization.
https://nilfoundation.github.io/ui-kit/?path=/docs/navigation-pagination--docs

@ukorvl
Copy link
Copy Markdown
Contributor

ukorvl commented Apr 21, 2025

"don't show incoming or outgoing tabs when there aren't any" - i think we still show it, am i right?

@ukorvl
Copy link
Copy Markdown
Contributor

ukorvl commented Apr 21, 2025

Minor adjustment is needed here - please align this elements vertically to the center
image
If needed change padding of CopyButton

@ukorvl
Copy link
Copy Markdown
Contributor

ukorvl commented Apr 21, 2025

When block is pending don't show an additional "Block" text and tabs
image

@ukorvl
Copy link
Copy Markdown
Contributor

ukorvl commented Apr 21, 2025

Everything else looks super, thanks a lot @Abeeujah
Please rebase your branch and fix comments before we merge this pull request.

@Abeeujah
Copy link
Copy Markdown
Contributor Author

Hi @ukorvl all requested changes has been implemented.

  • Pagination Component from UI-Kit has been Integrated.

  • Tabs are not shown when there isn't any transactions.
    localhost_5173_block_2_257237 (1)

  • The alignment between the CopyButton and the Text has been fixed.
    localhost_5173_block_3_257354

  • Block text is not shown when the block info is pending.
    Screenshot_20250423_134051

@Abeeujah Abeeujah requested a review from ukorvl April 23, 2025 13:31
@idea404 idea404 added this pull request to the merge queue Apr 24, 2025
Merged via the queue into NilFoundation:main with commit 92cd8db Apr 24, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ODHack12 Tag for issues which are suitable for ODHack week

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[explorer] Block page update

3 participants