Conversation
ukorvl
force-pushed
the
new-openrpc-client
branch
from
1c9677a to
78ce9ff
Compare
Rolaman
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This diff replaces
@openrpc/client-jswith custom implementation andjson-rpc-2.0for requests orchestration and requests' id management.Errors are now distinguished between network errors and json-rpc errors, and we can control the error handling manually. IT can be useful for providing custom error messages for users.
All kinds of transport are removed for now except
HTTPTransport. later we can add WebSockets support when needed.The client creates request and passes it to the transport layer. Transport layer executes request, handles errors and passes the response back to the client.
Bundle size (gzipped) is decreased from 8.29 Kb to 8.17Kb and moreover expensive
@openrpc/client-js(207 kB) is replaces with json-rpc-2.0 (134 kB) which is almost 2 times less.closes #250