Conversation
x-mass
force-pushed
the
sc-update-state-errors
branch
from
1d5d278 to
1113d8f
Compare
x-mass
force-pushed
the
sc-update-state-errors
branch
from
1113d8f to
51517e6
Compare
akokoshn
reviewed
Apr 25, 2025
- Handle `UpdateState` errors similarly to how we handle `CommitBatch` transaction errors. - If the data appears unsynced, invoke the resetter. - If the data is invalid, we currently call the resetter as well — this should be changed to `panic` in production. - Add new rollup contract errors to the error wrapper. - Remove the redundant simulation step in the proposer before transaction submission, as it is already performed during the `eth_estimateGas` call.
x-mass
force-pushed
the
sc-update-state-errors
branch
from
51517e6 to
1dbac35
Compare
akokoshn
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Summary
Handle errors the same way we do for CommitBatch transaction.
What Changes Were Made
UpdateStateerrors similarly to how we handleCommitBatchtransaction errors.panicin production.eth_estimateGascall.Checklist