Merged
Conversation
zadykian
force-pushed
the
sync-committee/full-reset-fix
branch
from
5c48caa to
7f45b63
Compare
zadykian
force-pushed
the
sync-committee/full-reset-fix
branch
from
7f45b63 to
e484289
Compare
x-mass
approved these changes
May 6, 2025
* Fixed `BlockStorage.ResetAllBatches(...)` by setting `latestBatchId` to nil; * Add `BloStorage.HasFreeSpace(...)` method to avoid unnecessary batch creation in `Aggregator`;
zadykian
force-pushed
the
sync-committee/full-reset-fix
branch
from
e484289 to
6a04dfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync Committee: Block Storage Fix
This PR addresses the following error encountered on
nil-devafter a full state reset was triggered:Changes:
BlockStorage.ResetAllBatches(...)by settinglatestBatchIdtonilBlockStorage.HasFreeSpace(...)method to avoid unnecessary batch creation inAggregator