Merged
Conversation
daringer
approved these changes
Jun 2, 2025
This patch prepares the migration from flit to poetry by: - explicitly setting version and description in pyproject.toml instead of inferring them dynamically, - removing the VERSION file as it is no longer needed after the previous step, and - adding `poetry check` to the CI.
poetry makes it easier to manage and keep track of the dependencies. This patch removes many of the unused targets from the Makefile as the contained operations are now much easier to achieve by running poetry directly.
This creates a distinction between optional dependencies that are relevant for end users and dependency groups that are only relevant for development or CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates from flit to poetry as a build system. This makes it easier to manage and keep track of our dependencies.
Side effects of this change are:
VERSIONfile, we specify the version inpyproject.toml.