helpers.b32padding: avoid adding 8 pads when none needed#654
Merged
robin-nitrokey merged 2 commits intoNitrokey:masterfrom Jun 1, 2025
Merged
helpers.b32padding: avoid adding 8 pads when none needed#654robin-nitrokey merged 2 commits intoNitrokey:masterfrom
robin-nitrokey merged 2 commits intoNitrokey:masterfrom
Conversation
Contributor
Author
|
and in this branch I also added regression test that verifies the fix (fails before, succeeds after) |
robin-nitrokey
force-pushed
the
nk3-padding-bugfix
branch
from
823b2de to
81f8669
Compare
Member
|
Good catch, thank you for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #653