Merged
Conversation
sosthene-nitrokey
approved these changes
Jun 24, 2025
Member
Author
|
That was actually my first implementation but I thought the POSIX timestamp would be easier to read in a filename. Changed to use the ISO timestamp instead: |
sosthene-nitrokey
approved these changes
Jun 24, 2025
Member
Author
|
Windows does not allow colons in filenames, so now without separators: |
This makes it easier to find the correct log file as they are now sorted by timestamp when sorting alphabetically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the log file naming scheme to use a
.logsuffix (fixes #317) and to include the timestamp (to make it easier to find the correct log file).nitropy.log.14t5shdlbecomesnitropy-1750752277-14t5shdl.log.