Show redirected URLs in the progress bar and in error messages#11184
Open
edolstra wants to merge 3 commits intoNixOS:masterfrom
Open
Show redirected URLs in the progress bar and in error messages#11184edolstra wants to merge 3 commits intoNixOS:masterfrom
edolstra wants to merge 3 commits intoNixOS:masterfrom
Conversation
tomberek
reviewed
Jul 29, 2024
| std::move(response), | ||
| "unable to %s '%s': %s (%d)", | ||
| request.verb(), request.uri, curl_easy_strerror(code), code); | ||
| request.verb(), result.urls.back(), curl_easy_strerror(code), code); |
Contributor
There was a problem hiding this comment.
Front and back urls printed would help users find out the cause.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
It's misleading / not helpful to refer to the original URL, especially in error messages. Fixes #9998.
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.