Remove warning that interpretation of .drv has changed#11878
Merged
edolstra merged 1 commit intoNixOS:masterfrom Nov 13, 2024
Merged
Conversation
This was first tagged as 2.15.0, 1½ years ago; plenty of time for everyone to catch up. By now, the warning is causing more confusion than that it is helpful, because passing a `.drv` or `drvPath` has legitimate use cases.
roberth
requested review from
Ericson2314 and
edolstra
and removed request for
edolstra
edolstra
approved these changes
Nov 13, 2024
edolstra
approved these changes
Nov 13, 2024
edolstra
added a commit
that referenced
this pull request
Nov 13, 2024
…1878 Remove warning that interpretation of .drv has changed (backport #11878)
Member
|
Good call! Glad the warning is gone for 2.24! |
edolstra
added a commit
that referenced
this pull request
Nov 26, 2024
…1878 Remove warning that interpretation of .drv has changed (backport #11878)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This was first tagged as 2.15.0, 1½ years ago; plenty of time for everyone to catch up.
By now, the warning is causing more confusion than that it is helpful, because passing a
.drvordrvPathhas legitimate use cases.I propose to also backport to 2.24.
Context
.drvspecial-casing for store path installable #7600Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.