Skip to content

gollum: 5.2.1 -> 5.2.3#132708

Closed
erictapen wants to merge 1 commit intoNixOS:masterfrom
erictapen:gollum-5.2.3
Closed

gollum: 5.2.1 -> 5.2.3#132708
erictapen wants to merge 1 commit intoNixOS:masterfrom
erictapen:gollum-5.2.3

Conversation

@erictapen
Copy link
Member

@erictapen erictapen commented Aug 4, 2021

This would add support for ReStructuredText und would complete #130131

But it doesn't merge yet as bundix creates a gemset.nix with a

  • hash mismatch for nokogiri
  • a nokogiri without a necessary dependency to mini_portile2, which fails to build even with the correct hash.

My guess is that this is currently blocked by nix-community/bundix#68.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@erictapen erictapen mentioned this pull request Aug 4, 2021
Open
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 4, 2021
@iv-nn iv-nn mentioned this pull request Aug 18, 2021
Open
@erictapen
gollum: 5.2.1 -> 5.2.3
ca8a0f9 
$ nix-shell -p bundix icu zlib cmake pkg-config openssl
$ rm Gemfile.lock
$ bundix -l
@stale
Copy link

stale bot commented Apr 25, 2022

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 25, 2022
@erictapen
Copy link
Member Author

erictapen commented Apr 25, 2022

Still relevant, but blocked by nix-community/bundix#68

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 25, 2022
@erictapen erictapen mentioned this pull request May 20, 2022
Merged
13 tasks
@erictapen
Copy link
Member Author

erictapen commented May 25, 2022

Superseeded in #171053

@erictapen erictapen closed this May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@erictapen