Skip to content

wastebin: init at 2.4.3#287455

Merged
cab404 merged 3 commits intoNixOS:masterfrom
pinpox:init-wastebin
Apr 1, 2024
Merged

wastebin: init at 2.4.3#287455
cab404 merged 3 commits intoNixOS:masterfrom
pinpox:init-wastebin

Conversation

@pinpox
Copy link
Copy Markdown
Member

@pinpox pinpox commented Feb 9, 2024 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Feb 9, 2024
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 9, 2024
@ofborg ofborg bot added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Feb 9, 2024
@pinpox pinpox force-pushed the init-wastebin branch 2 times, most recently from ef8d8f0 to 60345fa Compare February 9, 2024 21:06
@h7x4 h7x4 added 8.has: module (new) This PR adds a module in `nixos/` 8.has: tests This PR has tests labels Feb 10, 2024
@pinpox pinpox mentioned this pull request Feb 11, 2024
Merged
fsnkty
fsnkty reviewed Feb 14, 2024
View reviewed changes
Comment thread nixos/modules/services/misc/wastebin.nix Outdated
@pinpox pinpox requested a review from fsnkty February 21, 2024 21:28
fsnkty
fsnkty suggested changes Feb 21, 2024
View reviewed changes
Comment thread nixos/modules/services/misc/wastebin.nix Outdated
Comment thread nixos/modules/services/misc/wastebin.nix Outdated
Copy link
Copy Markdown
Member

@fsnkty fsnkty Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
default = {};

does this not do nothing?

Copy link
Copy Markdown
Member Author

@pinpox pinpox Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module failed to evaluate when nothing is set otherwise, so I added a empty default which is not `null``

Comment thread pkgs/by-name/wa/wastebin/package.nix Outdated
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Feb 22, 2024
@pinpox
Copy link
Copy Markdown
Member Author

pinpox commented Feb 22, 2024

Result of nixpkgs-review pr 287455 run on x86_64-linux 1

1 package blacklisted:
  • nixos-install-tools
1 package built:
  • wastebin

matthiasbeyer
matthiasbeyer reviewed Feb 23, 2024
View reviewed changes
Comment thread pkgs/by-name/wa/wastebin/package.nix Outdated
@pinpox
nixos/wastebin: init
3bc61ad 
Add module and test for wastebin
@ofborg ofborg bot requested a review from matthiasbeyer February 23, 2024 21:00
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2024
AndersonTorres
AndersonTorres approved these changes Mar 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine.

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 31, 2024
@nixos-discourse
Copy link
Copy Markdown

nixos-discourse commented Mar 31, 2024

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3728

cab404
cab404 approved these changes Mar 31, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@cab404 cab404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM <3

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Mar 31, 2024
@cab404 cab404 merged commit 7f797a6 into NixOS:master Apr 1, 2024
@pinpox pinpox deleted the init-wastebin branch April 2, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cab404 cab404 cab404 approved these changes

@matthiasbeyer matthiasbeyer Awaiting requested review from matthiasbeyer

+2 more reviewers

@fsnkty fsnkty fsnkty requested changes

@AndersonTorres AndersonTorres AndersonTorres approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 8.has: tests This PR has tests 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@pinpox @nixos-discourse @matthiasbeyer @AndersonTorres @cab404 @fsnkty @wegank @h7x4