Conversation
remove trailing white spaces
|
Thank you for this, @MyGitHubBlueberry — could you change the commit message and PR title to match the convention for new packages? ofborg is very picky and only understands commits of a specific format. |
There was a problem hiding this comment.
This also has to be added to pkgs/top-level/python-packages.nix or it won't actually be accessible in Nixpkgs. i.e., checking out this PR as is, nix-build -A python3Packages.pywal16 does not work.
On it. |
suggestion accepted Co-authored-by: Qyriad <qyriad@gmail.com>
|
@Qyriad, thank you, all done. |
Qyriad
left a comment
There was a problem hiding this comment.
This still needs an entry in pkgs/top-level/python-packages.nix or it won't actually be accessible in Nixpkgs. If I check out this PR right now, I can't actually build the package with something like nix-build -A python3Packages.pywal16 or nix build '.#python3Packages.pywal16'
Entry in python-packages
|
@Qyriad sorry, I'm not very comfortable with git and github and I only now noticed that you actually suggested changes and not only description how to make them. |
updated maintainer name in default.nix with lowercase
|
@Qyriad is there anything else I need to do? |
Qyriad
left a comment
There was a problem hiding this comment.
Result of nixpkgs-review run on x86_64-linux 1
4 packages built:
- python311Packages.pywal16
- python311Packages.pywal16.dist
- python312Packages.pywal16
- python312Packages.pywal16.dist
Result of nixpkgs-review run on aarch64-darwin 1
4 packages built:
- python311Packages.pywal16
- python311Packages.pywal16.dist
- python312Packages.pywal16
- python312Packages.pywal16.dist
|
LGTM, sorry for the wait |
|
@Qyriad there is no rash, thank you for your time. |
|
Those checkboxes (I think) are for things you did. There is now at least one approval though, so hopefully a committer will be able to look at this PR soon |
MyGitHubBlueberry
left a comment
There was a problem hiding this comment.
Thank you for you review :)
|
I'm not sure what's going on here, but the package was added in #316805 in a different way, so this PR can't be merged. Please add the patches in another PR if they are necessary. |
Description of changes
This is fork of pywal, named pywal16, maintained by eylles.
This package generates color palletes based on wallpaper, but it does it in 16 and not 8 color palette.
Some packages support pywal16 already, as original pywal replacement wpgtk will be a good example.
Motivation:
Note:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.