Skip to content

pywal16: init at 3.5.3#312684

Closed
MyGitHubBlueberry wants to merge 6 commits intoNixOS:masterfrom
MyGitHubBlueberry:master
Closed

pywal16: init at 3.5.3#312684
MyGitHubBlueberry wants to merge 6 commits intoNixOS:masterfrom
MyGitHubBlueberry:master

Conversation

@MyGitHubBlueberry
Copy link

@MyGitHubBlueberry MyGitHubBlueberry commented May 18, 2024

Description of changes

This is fork of pywal, named pywal16, maintained by eylles.
This package generates color palletes based on wallpaper, but it does it in 16 and not 8 color palette.
Some packages support pywal16 already, as original pywal replacement wpgtk will be a good example.

Motivation:

  • This package is quite nice, I would use it myself
  • Fixes pywal 8 color problem
  • eylles, the package developer, is building handy git repo whith a templates for gui apps, and as person who uses wallust (pywal alternative), I would love to switch to something with gtk-qt support.

Note:

  • I build package on my nixos with nix flakes and it works all right. Idk if it is "applicable" testing, so I won't tick this box.
  • I have read contributing.md, but I'm not sure if I did everything ok, so this box is also unticked.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

MyGitHubBlueberry and others added 3 commits May 18, 2024 16:10
@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels May 18, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 18, 2024
@Qyriad
Copy link
Member

Qyriad commented May 18, 2024

Thank you for this, @MyGitHubBlueberry — could you change the commit message and PR title to match the convention for new packages? ofborg is very picky and only understands commits of a specific format.

Copy link
Member

@Qyriad Qyriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also has to be added to pkgs/top-level/python-packages.nix or it won't actually be accessible in Nixpkgs. i.e., checking out this PR as is, nix-build -A python3Packages.pywal16 does not work.

@MyGitHubBlueberry
Copy link
Author

Thank you for this, @MyGitHubBlueberry — could you change the commit message and PR title to match the convention for new packages? ofborg is very picky and only understands commits of a specific format.

On it.

@MyGitHubBlueberry MyGitHubBlueberry changed the title pywal16 package added pywal16: init at 3.5.3 May 19, 2024
suggestion accepted

Co-authored-by: Qyriad <qyriad@gmail.com>
@MyGitHubBlueberry
Copy link
Author

@Qyriad, thank you, all done.

@MyGitHubBlueberry MyGitHubBlueberry requested a review from Qyriad May 19, 2024 08:53
Copy link
Member

@Qyriad Qyriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs an entry in pkgs/top-level/python-packages.nix or it won't actually be accessible in Nixpkgs. If I check out this PR right now, I can't actually build the package with something like nix-build -A python3Packages.pywal16 or nix build '.#python3Packages.pywal16'

Entry in python-packages
@MyGitHubBlueberry
Copy link
Author

@Qyriad sorry, I'm not very comfortable with git and github and I only now noticed that you actually suggested changes and not only description how to make them.
Again, thank you :)

updated maintainer name in default.nix with lowercase
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 20, 2024
@MyGitHubBlueberry MyGitHubBlueberry requested a review from Qyriad May 20, 2024 09:51
@MyGitHubBlueberry
Copy link
Author

@Qyriad is there anything else I need to do?

Copy link
Member

@Qyriad Qyriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review run on x86_64-linux 1

4 packages built:
  • python311Packages.pywal16
  • python311Packages.pywal16.dist
  • python312Packages.pywal16
  • python312Packages.pywal16.dist

Result of nixpkgs-review run on aarch64-darwin 1

4 packages built:
  • python311Packages.pywal16
  • python311Packages.pywal16.dist
  • python312Packages.pywal16
  • python312Packages.pywal16.dist

@Qyriad
Copy link
Member

Qyriad commented May 23, 2024

LGTM, sorry for the wait

@MyGitHubBlueberry
Copy link
Author

@Qyriad there is no rash, thank you for your time.
You sent reviews, so can I tick the box aarch64-darwin?
And still, do I need to do anything, or should I just wait for the package to be merged?

@Qyriad
Copy link
Member

Qyriad commented May 25, 2024

Those checkboxes (I think) are for things you did. There is now at least one approval though, so hopefully a committer will be able to look at this PR soon

@Qyriad Qyriad added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 25, 2024
Copy link
Author

@MyGitHubBlueberry MyGitHubBlueberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for you review :)

@wegank
Copy link
Member

wegank commented Jul 11, 2024

I'm not sure what's going on here, but the package was added in #316805 in a different way, so this PR can't be merged. Please add the patches in another PR if they are necessary.

@wegank wegank closed this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants