Skip to content

libspatialindex: 1.9.3 -> 2.0.0#318245

Merged
imincik merged 1 commit intoNixOS:masterfrom
imincik:libspatialindex-2.0.0
Aug 26, 2024
Merged

libspatialindex: 1.9.3 -> 2.0.0#318245
imincik merged 1 commit intoNixOS:masterfrom
imincik:libspatialindex-2.0.0

Conversation

@imincik
Copy link
Copy Markdown
Contributor

@imincik imincik commented Jun 8, 2024 •
edited
Loading

Description of changes

Update libspatialindex to the latest major version.

There are no significant major enhancements or refactorings that should change
any behaviors. It had been a long time (almost 5 years!) since a release and
2.0.0 was the next version number...

Release notes:
https://github.com/libspatialindex/libspatialindex/releases/tag/2.0.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@imincik imincik marked this pull request as draft June 8, 2024 10:28
@imincik imincik force-pushed the libspatialindex-2.0.0 branch 2 times, most recently from 6826d7d to 221f88a Compare June 8, 2024 10:59
@ofborg ofborg bot requested review from l0b0, nh2, nialov, sikmir and willcohen June 8, 2024 11:12
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jun 8, 2024
sikmir
sikmir reviewed Jun 8, 2024
View reviewed changes
@imincik imincik force-pushed the libspatialindex-2.0.0 branch from 221f88a to 6e34f3d Compare June 8, 2024 19:39
@imincik imincik marked this pull request as ready for review June 8, 2024 19:40
@imincik imincik mentioned this pull request Jun 8, 2024
Open
@imincik
Copy link
Copy Markdown
Contributor Author

imincik commented Jun 8, 2024 •
edited
Loading

Result of nixpkgs-review pr 318245 run on x86_64-linux 1

50 packages failed to build:
  • gerbolyze
  • gerbolyze.dist
  • python311Packages.bsuite
  • python311Packages.bsuite.dist
  • python311Packages.folium
  • python311Packages.folium.dist
  • python311Packages.geodatasets
  • python311Packages.geodatasets.dist
  • python311Packages.geopandas
  • python311Packages.geopandas.dist
  • python311Packages.gerbonara
  • python311Packages.gerbonara.dist
  • python311Packages.libpysal
  • python311Packages.libpysal.dist
  • python311Packages.mapclassify
  • python311Packages.mapclassify.dist
  • python311Packages.osmnx
  • python311Packages.osmnx.dist
  • python311Packages.plotnine
  • python311Packages.plotnine.dist
  • python311Packages.rtree
  • python311Packages.rtree.dist
  • python311Packages.shimmy
  • python311Packages.shimmy.dist
  • spyder (python311Packages.spyder)
  • spyder.dist (python311Packages.spyder.dist)
  • python311Packages.wktutils
  • python311Packages.wktutils.dist
  • python312Packages.bsuite
  • python312Packages.bsuite.dist
  • python312Packages.folium
  • python312Packages.folium.dist
  • python312Packages.geodatasets
  • python312Packages.geodatasets.dist
  • python312Packages.geopandas
  • python312Packages.geopandas.dist
  • python312Packages.gerbonara
  • python312Packages.gerbonara.dist
  • python312Packages.libpysal
  • python312Packages.libpysal.dist
  • python312Packages.mapclassify
  • python312Packages.mapclassify.dist
  • python312Packages.osmnx
  • python312Packages.osmnx.dist
  • python312Packages.plotnine
  • python312Packages.plotnine.dist
  • python312Packages.rtree
  • python312Packages.rtree.dist
  • python312Packages.wktutils
  • python312Packages.wktutils.dist
7 packages built:
  • libspatialindex
  • minetest
  • minetest-touch
  • minetestclient
  • minetestserver
  • qgis
  • qgis-ltr
  • python311Packages.rtree.log
============================= test session starts ==============================                                                                                                                                                              │
│platform linux -- Python 3.11.9, pytest-8.1.1, pluggy-1.4.0                                                                                                                                                                                   │
│rootdir: /build/source                                                                                                                                                                                                                        │
│configfile: pyproject.toml                                                                                                                                                                                                                    │
│collecting ... ^Mcollected 40 items                                                                                                                                                                                                           │
│                                                                                                                                                                                                                                              │
│tests/test_finder.py ..                                                  [  5%]                                                                                                                                                               │
│tests/test_index.py F.......x............................                [ 97%]                                                                                                                                                               │
│tests/test_tpr.py .                                                      [100%]                                                                                                                                                               │
│                                                                                                                                                                                                                                              │
│=================================== FAILURES ===================================                                                                                                                                                              │
│______________________ IndexVersion.test_libsidx_version _______________________                                                                                                                                                              │
│                                                                                                                                                                                                                                              │
│self = <tests.test_index.IndexVersion testMethod=test_libsidx_version>                                                                                                                                                                        │
│                                                                                                                                                                                                                                              │
│    def test_libsidx_version(self) -> None:                                                                                                                                                                                                   │
│>       self.assertTrue(index.major_version == 1)                                                                                                                                                                                             │
│E       AssertionError: False is not true                                                                                                                                                                                                     │
│                                                                                                                                                                                                                                              │
│/build/source/tests/test_index.py:47: AssertionError

@ofborg ofborg bot requested a review from sikmir June 8, 2024 20:27
@imincik
Copy link
Copy Markdown
Contributor Author

imincik commented Jun 8, 2024 •
edited
Loading

rtrees test_libsidx_version test was removed in Toblerity/rtree#313

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jun 8, 2024
@imincik
Copy link
Copy Markdown
Contributor Author

imincik commented Jun 8, 2024

Result of nixpkgs-review pr 318245 run on x86_64-linux 1

2 packages failed to build:
  • gerbolyze
  • gerbolyze.dist
55 packages built:
  • libspatialindex
  • minetest
  • minetest-touch
  • minetestclient
  • minetestserver
  • python311Packages.bsuite
  • python311Packages.bsuite.dist
  • python311Packages.folium
  • python311Packages.folium.dist
  • python311Packages.geodatasets
  • python311Packages.geodatasets.dist
  • python311Packages.geopandas
  • python311Packages.geopandas.dist
  • python311Packages.gerbonara
  • python311Packages.gerbonara.dist
  • python311Packages.libpysal
  • python311Packages.libpysal.dist
  • python311Packages.mapclassify
  • python311Packages.mapclassify.dist
  • python311Packages.osmnx
  • python311Packages.osmnx.dist
  • python311Packages.plotnine
  • python311Packages.plotnine.dist
  • python311Packages.rtree
  • python311Packages.rtree.dist
  • python311Packages.shimmy
  • python311Packages.shimmy.dist
  • spyder (python311Packages.spyder)
  • spyder.dist (python311Packages.spyder.dist)
  • python311Packages.wktutils
  • python311Packages.wktutils.dist
  • python312Packages.bsuite
  • python312Packages.bsuite.dist
  • python312Packages.folium
  • python312Packages.folium.dist
  • python312Packages.geodatasets
  • python312Packages.geodatasets.dist
  • python312Packages.geopandas
  • python312Packages.geopandas.dist
  • python312Packages.gerbonara
  • python312Packages.gerbonara.dist
  • python312Packages.libpysal
  • python312Packages.libpysal.dist
  • python312Packages.mapclassify
  • python312Packages.mapclassify.dist
  • python312Packages.osmnx
  • python312Packages.osmnx.dist
  • python312Packages.plotnine
  • python312Packages.plotnine.dist
  • python312Packages.rtree
  • python312Packages.rtree.dist
  • python312Packages.wktutils
  • python312Packages.wktutils.dist
  • qgis
  • qgis-ltr

@ofborg ofborg bot requested a review from bgamari June 8, 2024 22:44
@imincik
Copy link
Copy Markdown
Contributor Author

imincik commented Jul 30, 2024

Result of nixpkgs-review pr 318245 run on x86_64-linux 1

54 packages failed to build:
  • gerbolyze
  • gerbolyze.dist
  • python311Packages.bsuite
  • python311Packages.bsuite.dist
  • python311Packages.folium
  • python311Packages.folium.dist
  • python311Packages.geodatasets
  • python311Packages.geodatasets.dist
  • python311Packages.geopandas
  • python311Packages.geopandas.dist
  • python311Packages.gerbonara
  • python311Packages.gerbonara.dist
  • python311Packages.libpysal
  • python311Packages.libpysal.dist
  • python311Packages.mapclassify
  • python311Packages.mapclassify.dist
  • python311Packages.osmnx
  • python311Packages.osmnx.dist
  • python311Packages.plotnine
  • python311Packages.plotnine.dist
  • python311Packages.rtree
  • python311Packages.rtree.dist
  • python311Packages.shimmy
  • python311Packages.shimmy.dist
  • python311Packages.spyder
  • python311Packages.spyder.dist
  • python311Packages.wktutils
  • python311Packages.wktutils.dist
  • python312Packages.bsuite
  • python312Packages.bsuite.dist
  • python312Packages.folium
  • python312Packages.folium.dist
  • python312Packages.geodatasets
  • python312Packages.geodatasets.dist
  • python312Packages.geopandas
  • python312Packages.geopandas.dist
  • python312Packages.gerbonara
  • python312Packages.gerbonara.dist
  • python312Packages.libpysal
  • python312Packages.libpysal.dist
  • python312Packages.mapclassify
  • python312Packages.mapclassify.dist
  • python312Packages.osmnx
  • python312Packages.osmnx.dist
  • python312Packages.plotnine
  • python312Packages.plotnine.dist
  • python312Packages.rtree
  • python312Packages.rtree.dist
  • python312Packages.wktutils
  • python312Packages.wktutils.dist
  • qgis
  • qgis-ltr
  • spyder
  • spyder.dist
5 packages built:
  • libspatialindex
  • minetest
  • minetest-touch
  • minetestclient
  • minetestserver

@imincik imincik force-pushed the libspatialindex-2.0.0 branch from 88acc7f to 9bea416 Compare July 30, 2024 10:39
@github-actions github-actions bot removed the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 30, 2024
@imincik
Copy link
Copy Markdown
Contributor Author

imincik commented Jul 30, 2024

PR rebased with master.

@imincik
Copy link
Copy Markdown
Contributor Author

imincik commented Jul 30, 2024 •
edited
Loading

Result of nixpkgs-review pr 318245 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • python312Packages.shimmy
  • python312Packages.shimmy.dist
4 packages failed to build:
  • spyder (python312Packages.spyder)
  • spyder.dist (python312Packages.spyder.dist)
  • qgis
  • qgis-ltr
63 packages built:
  • gerbolyze
  • gerbolyze.dist
  • libspatialindex
  • minetest
  • minetest-touch
  • minetestclient
  • minetestserver
  • python311Packages.bsuite
  • python311Packages.bsuite.dist
  • python311Packages.folium
  • python311Packages.folium.dist
  • python311Packages.geodatasets
  • python311Packages.geodatasets.dist
  • python311Packages.geopandas
  • python311Packages.geopandas.dist
  • python311Packages.gerbonara
  • python311Packages.gerbonara.dist
  • python311Packages.inequality
  • python311Packages.inequality.dist
  • python311Packages.libpysal
  • python311Packages.libpysal.dist
  • python311Packages.mapclassify
  • python311Packages.mapclassify.dist
  • python311Packages.momepy
  • python311Packages.momepy.dist
  • python311Packages.osmnx
  • python311Packages.osmnx.dist
  • python311Packages.plotnine
  • python311Packages.plotnine.dist
  • python311Packages.rtree
  • python311Packages.rtree.dist
  • python311Packages.shimmy
  • python311Packages.shimmy.dist
  • python311Packages.spyder
  • python311Packages.spyder.dist
  • python311Packages.wktutils
  • python311Packages.wktutils.dist
  • python312Packages.bsuite
  • python312Packages.bsuite.dist
  • python312Packages.folium
  • python312Packages.folium.dist
  • python312Packages.geodatasets
  • python312Packages.geodatasets.dist
  • python312Packages.geopandas
  • python312Packages.geopandas.dist
  • python312Packages.gerbonara
  • python312Packages.gerbonara.dist
  • python312Packages.inequality
  • python312Packages.inequality.dist
  • python312Packages.libpysal
  • python312Packages.libpysal.dist
  • python312Packages.mapclassify
  • python312Packages.mapclassify.dist
  • python312Packages.momepy
  • python312Packages.momepy.dist
  • python312Packages.osmnx
  • python312Packages.osmnx.dist
  • python312Packages.plotnine
  • python312Packages.plotnine.dist
  • python312Packages.rtree
  • python312Packages.rtree.dist
  • python312Packages.wktutils
  • python312Packages.wktutils.dist

Logs

qgis (not caused by this PR, fails in master as well):

  > configure: error: *** Unable to locate suitable (>=1.7.1) PDAL library.

@ofborg ofborg bot requested a review from autra July 30, 2024 11:23
l0b0
l0b0 approved these changes Aug 26, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@l0b0 l0b0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM; untested.

@imincik imincik merged commit edcb325 into NixOS:master Aug 26, 2024
imincik added a commit to imincik/geospatial-nix that referenced this pull request Aug 29, 2024
@imincik
libspatialindex: 1.9.3 -> 2.0.0
7826af1 
Nixpkgs PR:
NixOS/nixpkgs#318245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nh2 nh2 Awaiting requested review from nh2

@willcohen willcohen Awaiting requested review from willcohen

@nialov nialov Awaiting requested review from nialov

@sikmir sikmir Awaiting requested review from sikmir

@bgamari bgamari Awaiting requested review from bgamari

@autra autra Awaiting requested review from autra

1 more reviewer

@l0b0 l0b0 l0b0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@imincik @l0b0 @sikmir