fetchurl: fix overrideAttrs working as expect with hash#459487
Closed
SuperSandro2000 wants to merge 1 commit intoNixOS:masterfrom
Closed
fetchurl: fix overrideAttrs working as expect with hash#459487SuperSandro2000 wants to merge 1 commit intoNixOS:masterfrom
SuperSandro2000 wants to merge 1 commit intoNixOS:masterfrom
Conversation
The following example did not work before and does with this change:
(fetchurl {
url = "...";
hash = "sha256-..."
}).overrideAttrs (_: {
hash = lib.fakeHash;
}
SuperSandro2000
force-pushed
the
fetchurl-overrideAtts-hash
branch
from
645209b to
f722841
Compare
nixpkgs-ci
bot
added
10.rebuild-linux: 11-100
ShamrockLee
reviewed
Nov 9, 2025
Contributor
ShamrockLee
left a comment
ShamrockLee
left a comment
There was a problem hiding this comment.
The current changes would prevent overriding with hash when fetchur has been called with sha256.
How about making only hash overridiable?
The suggested changes are tested locally with ci/eval and remote builders, and the changed packages are only test cases.
| @@ -190,7 +190,7 @@ | |||
| if hash != "" then | |||
Contributor
There was a problem hiding this comment.
Suggested change
| if hash != "" then | |
| if finalAttrs.hash != "" then |
| { | ||
| outputHashAlgo = "sha512"; | ||
| outputHash = sha512; | ||
| outputHash = finalAttrs.sha512; |
Contributor
There was a problem hiding this comment.
Suggested change
| outputHash = finalAttrs.sha512; | |
| outputHash = sha512; |
| { | ||
| outputHashAlgo = "sha256"; | ||
| outputHash = sha256; | ||
| outputHash = finalAttrs.sha256; |
Contributor
There was a problem hiding this comment.
Suggested change
| outputHash = finalAttrs.sha256; | |
| outputHash = sha256; |
| { | ||
| outputHashAlgo = "sha1"; | ||
| outputHash = sha1; | ||
| outputHash = finalAttrs.sha1; |
Contributor
There was a problem hiding this comment.
Suggested change
| outputHash = finalAttrs.sha1; | |
| outputHash = sha1; |
Comment on lines
+264
to
+270
| # Make overrideAttrs behave as expected | ||
| inherit | ||
| hash | ||
| sha1 | ||
| sha256 | ||
| sha512 | ||
| ; |
Contributor
There was a problem hiding this comment.
This could be done from the excludeDrvArgNames side, as we don't need them to be present all the time.
Suggested change
| # Make overrideAttrs behave as expected | |
| inherit | |
| hash | |
| sha1 | |
| sha256 | |
| sha512 | |
| ; |
Comment on lines
66
to
70
| # Hash attributes will be map to the corresponding outputHash* | ||
| "hash" | ||
| "sha1" | ||
| "sha256" | ||
| "sha512" |
Contributor
There was a problem hiding this comment.
Pass hash when specified.
Suggested change
| # Hash attributes will be map to the corresponding outputHash* | |
| "sha1" | |
| "sha256" | |
| "sha512" |
13 tasks
Member
Author
|
Closing in favor of the other PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following example did not work before and does with this change:
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.