Skip to content

python3Packages.tensorflow-datasets: fetch patch to fix pillow 12 compat#463025

Merged
kirillrdy merged 1 commit intoNixOS:masterfrom
GaetanLepage:tensorflow-datasets
Nov 21, 2025
Merged

python3Packages.tensorflow-datasets: fetch patch to fix pillow 12 compat#463025
kirillrdy merged 1 commit intoNixOS:masterfrom
GaetanLepage:tensorflow-datasets

Conversation

@GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Nov 18, 2025

Things done

cc @ndl

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot requested a review from ndl November 18, 2025 22:51
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Nov 18, 2025
@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 463025
Commit: 678099ff5950a4f4daa3b48e9796107a7d1e7264


x86_64-linux

✅ 8 packages built:
  • python312Packages.dm-sonnet
  • python312Packages.dm-sonnet.dist
  • python312Packages.tensorflow-datasets
  • python312Packages.tensorflow-datasets.dist
  • python313Packages.dm-sonnet
  • python313Packages.dm-sonnet.dist
  • python313Packages.tensorflow-datasets
  • python313Packages.tensorflow-datasets.dist

@@ -143,6 +143,16 @@ buildPythonPackage rec {
# RuntimeError: Unable to pickle fn CallableWrapperDoFn...: maximum recursion depth exceeded
# https://github.com/tensorflow/datasets/issues/11055
"test_download_and_prepare_as_dataset"

# TypeError: Cannot handle this data type: (1, 1, 4), <u2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please report to upstream

Copy link
Contributor Author

@GaetanLepage GaetanLepage Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually I do it, but lately there were so many broken packages to deal with that I wanted to iterate slightly faster.
But anyway, I reported the issue upstream and added a comment in the file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we should vendor the patch instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@GaetanLepage GaetanLepage changed the title python3Packages.tensorflow-datasets: skip failing tests python3Packages.tensorflow-datasets: fetch patch to fix pillow 12 compat Nov 21, 2025
@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 463025
Commit: 5e0ffdda4ba5fd01411a40f35da08bc0f3218b11


x86_64-linux

✅ 8 packages built:
  • python312Packages.dm-sonnet
  • python312Packages.dm-sonnet.dist
  • python312Packages.tensorflow-datasets
  • python312Packages.tensorflow-datasets.dist
  • python313Packages.dm-sonnet
  • python313Packages.dm-sonnet.dist
  • python313Packages.tensorflow-datasets
  • python313Packages.tensorflow-datasets.dist

@kirillrdy kirillrdy added this pull request to the merge queue Nov 21, 2025
Merged via the queue into NixOS:master with commit aefb331 Nov 21, 2025
29 of 32 checks passed
@GaetanLepage GaetanLepage deleted the tensorflow-datasets branch November 21, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants