{zig, zls}: add 0.16.0 versions; default to v0.16.0#509719
{zig, zls}: add 0.16.0 versions; default to v0.16.0#509719ddogfoodd wants to merge 8 commits intoNixOS:masterfrom
Conversation
|
@NixOS/nixpkgs-vet nixpkgs-vet reports: I am not sure if that's really something I should do as I couldn't find an example in Could you please take a look? |
Eveeifyeve
left a comment
There was a problem hiding this comment.
#509719 (comment) is a known issue that should be fixed in a followup pr. CC #205690
|
I would like to wait for zls_0_16 to release so we can update the default versions of zig and zls to match. If you would rather update zig default to 0.16.0 immediately, let me know. |
|
I'd prefer that |
|
It'll be some time before ZLS even supports 0.16 after looking at the commits. They only recently bumped to a newer pre-release 0.16 dev version. This should be good to merge imo. |
add zig version 0.16.0 as zig_0_16
|
My bad, misunderstood at first. |
|
NotAShelf
left a comment
There was a problem hiding this comment.
Can't wait for all of my projects to be broken
Modernize by using `zigBuildFlags` instead of linking deps in `postConfigure`. Add zls_0_16. Release Notes: https://zigtools.org/zls/releases/0.16.0/ Diff: zigtools/zls@0.15.1...0.16.0
|
Thank you for the review runs! I pinned zig to zig_0_15 for packages that require 0.15. However, |
Fixed the build.zig.zon.nix file by running the current version of zon2nix on the odiff tagged build.zig.zon file. Further, removed `?ref=` parts in fetchgit urls and corrected some hashed.
Fix build by using the current version of zon2nix to generate the build.zig.zon.nix
|
|
|
You need to enable |
I hope setting for all versions is fine too. The message telling me to add it to Anyway, hope this does it now. Thank you for mentioning it again! |
|
|
|
Unfortunately I don't have darwin machines. It's hard for me to fix without testing, so feel free to request some changes if anyone got the time and means to fix the remaining failed builds. |
Add zig version 0.16.0 as
zig_0_16.Release Notes: https://ziglang.org/download/0.16.0/release-notes.html
Add zls version 0.16.0 as
zls_0_16.Release Notes: https://zigtools.org/zls/releases/0.16.0/
Diff: zigtools/zls@0.15.1...0.16.0
Modernize zls by using
zigBuildFlagsinstead of linking deps inpostConfigure. When usingpostConfigureI couldn't build because nix didn't use the cache and couldn't fetch the deps. I looked at more recent PRs of zig packages and adapted the approach used in #500184.Set the default version of zig to
zig_0_16and zls tozls_0_16.Pinned
zigtozig_0_15for packages that require zig version 0.15.Fixed the builds of
odiffandriver-ultitileby updating theirbuild.zig.zon.nixfiles. I re-ranzon2nixto generate them. For odiff, I had to manually remove?ref=parts fromfetchgiturls and correct some hashes.Set
__structuredAttrs = true;for zig and zls.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.