Resize segment mapping rewritten sections if needed #482#485
Merged
bors[bot] merged 1 commit intoNixOS:masterfrom Apr 23, 2023
Merged
Resize segment mapping rewritten sections if needed #482#485bors[bot] merged 1 commit intoNixOS:masterfrom
bors[bot] merged 1 commit intoNixOS:masterfrom
Conversation
brenoguim
force-pushed
the
breno.482_2
branch
2 times, most recently
from
1a07a22 to
f290cf2
Compare
Mic92
reviewed
Mar 21, 2023
Member
|
@brenoguim thanks for taking over this one. I did look at ldc in the past but not long enough to understanding the issue. |
Mic92
force-pushed
the
breno.482_2
branch
3 times, most recently
from
d08bb38 to
061a7f9
Compare
Member
|
bors merge |
Contributor
This was referenced Apr 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, the first segment in the executable doesn't map all content up to the next segment. So, sometimes there will be space in the beginning of the file to rewrite sections, but the first segment won't map the whole thing.
In this case, we extend the that segment to include all the needed space.
For this test I had to zero all the progbits and zip the binary. It went from 6MB to 166kb.