This repository was archived by the owner on Mar 30, 2026. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 727
feat: Add interactive pause after checking quota #443
Open
jcromero
wants to merge
1
commit into
NoeFabris:main
Choose a base branch
from
jcromero:fix/quota-check-interactive
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -2730,6 +2730,12 @@ export const createAntigravityPlugin = (providerId: string) => async ( | |||||||||||||||||||||||||||||||||||||||||
| await saveAccounts(existingStorage); | ||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||
| console.log(""); | ||||||||||||||||||||||||||||||||||||||||||
| console.log("\nPress Enter to return to the menu..."); | ||||||||||||||||||||||||||||||||||||||||||
| const { createInterface } = await import("node:readline/promises"); | ||||||||||||||||||||||||||||||||||||||||||
| const { stdin, stdout } = await import("node:process"); | ||||||||||||||||||||||||||||||||||||||||||
| const rl = createInterface({ input: stdin, output: stdout }); | ||||||||||||||||||||||||||||||||||||||||||
| await rl.question(""); | ||||||||||||||||||||||||||||||||||||||||||
| rl.close(); | ||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+2734
to
+2738
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. missing try-finally block for readline cleanup
Suggested change
Prompt To Fix With AIThis is a comment left during a code review.
Path: src/plugin.ts
Line: 2734:2738
Comment:
missing try-finally block for readline cleanup
```suggestion
const { createInterface } = await import("node:readline/promises");
const { stdin, stdout } = await import("node:process");
const rl = createInterface({ input: stdin, output: stdout });
try {
await rl.question("");
} finally {
rl.close();
}
```
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+2737
to
+2738
|
||||||||||||||||||||||||||||||||||||||||||
| await rl.question(""); | |
| rl.close(); | |
| try { | |
| await rl.question(""); | |
| } finally { | |
| rl.close(); | |
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This prints an extra blank line because there’s already a
console.log("")immediately above and this string also starts with\n. Consider removing one of the newlines to avoid double-spacing the prompt.