[IMP] Move the constraint on uniqueness for cutoff date at line level using a configuration #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @jbaudoux, @alexis-via, |
Author
jbaudoux
suggested changes
Jul 9, 2025
Contributor
jbaudoux
left a comment
jbaudoux
left a comment
There was a problem hiding this comment.
you need to make one commit per module
…ff date at line level + Add the possibility to create several cutoff with the same date + Add a configuration to check cutoff date unicity either on lines or on the whole cutoff
Business case can be :
- One user (A) creates a cutoff for some account moves. Another user (B) creates other moves, then wants to see those moves in a cutoff.
However, B does not want to interfere with the cutoff A already made. B creates a new cutoff with the same date as the one of A, and when he generates lines,
only retrieves the one that were not already in the cutoff of A.
- One user wants to create several cutoff at the same date, but for different journals/accounts
…toff date unicity either on lines or on the whole cutoff
lmarion-source
force-pushed
the
16.0-multiple_cutoff
branch
from
024e058 to
58db23e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the box is not checked in configurations, the uniqueness is checked at the cutoff level (as previously done). If we need to create several cutoff at the same date for different journals/accounts, we can check the box and the check will be done at the cutoff line level.
Business case can be :
One user (A) creates a cutoff for some account moves. Another user (B) creates other moves, then wants to see those moves in a cutoff.
However, B does not want to interfere with the cutoff A already made. B creates a new cutoff with the same date as the one of A, and when he generates lines,
only retrieves the one that were not already in the cutoff of A.
One user wants to create several cutoff at the same date, but for different journals/accounts