[MIG] product_operating_unit: Migration to 17.0 #668

ghost · 2024-05-28T09:54:23Z

Some changes (security rules) are based on changes made in the base modules #667

I removed domains on operating units fields for two reasons:

A operating unit manager is not necessarily assigned to a operating unit (

operating-unit/operating_unit/models/res_users.py

Line 76 in 025e778

if user._origin.has_group("operating_unit.group_manager_operating_unit"):

) so in this case, the user id is not present in the user_ids field of the operating unit
The security rules already filter the units I can see.

Depends on:

[MIG] operating_unit: Migration to 17.0 #667

AaronHForgeFlow · 2024-05-28T10:04:56Z

/ocabot migration product_operating_unit

SilvioC2C

Small improvements suggested.
CI is red, though.

SilvioC2C · 2024-06-04T13:32:01Z

product_operating_unit/models/product_category.py

+                category_ou_ids = rec.operating_unit_ids.ids
+                for product in products:
+                    ou_ids = product.operating_unit_ids.ids
+                    ou_ids.extend(category_ou_ids)
+                    product.operating_unit_ids = [Command.set(ou_ids)]


Nitpicking: might as well use records directly, instead of ids

at least it's worth it to try if it fails on this

Logic updated with records instead of ids. Thanks for the review 👍

SilvioC2C · 2024-06-04T13:33:36Z

product_operating_unit/models/product_template.py

+        if self.categ_id and self.categ_id.operating_unit_ids:
+            return [(6, 0, self.categ_id.operating_unit_ids.ids)]


Since this method is used as a default method, self.categ_id will always be empty.

For now, I simply removed the if statement but I'm wondering if the default is still needed with the compute based on the categ_id

SilvioC2C · 2024-06-04T13:37:53Z

product_operating_unit/models/product_template.py

+    @api.depends("categ_id")
+    def _compute_operating_unit_ids(self):
+        for record in self:
+            if record.categ_id.operating_unit_ids:


I think you can remove this if statement: if the category is changed to a category with no OU, the field can be safely emptied

Statement removed 👍

yankinmax · 2024-06-08T06:19:27Z

you need to add test-requirements.txt file in operating-unit folder with such content

odoo-addon-operating_unit @ git+https://github.com/OCA/operating-unit.git@refs/pull/667/head#subdirectory=operating_unit

this should fix the build

yankinmax · 2024-06-11T09:08:29Z

@jdidderen-nsi thanks for the migration

Camille0907

Migration LGTM, thanks

ghost · 2024-06-24T09:24:29Z

product_operating_unit/models/product_template.py

+        compute="_compute_operating_unit_ids",
+        store=True,
+        readonly=False,
+        default=lambda self: self._default_operating_unit_ids(),


This was one of my thoughts, given the compute based on the categ_id
So piece of code is removed

gurneyalex · 2024-07-03T09:50:55Z

#667 is now merged 😸

yankinmax · 2024-07-08T13:44:50Z

@jdidderen-nsi can you please remove dependency commit and rebase?
operating_unit is merged:

[MIG] operating_unit: Migration to 17.0 #667

…the product template.

Co-Authored-By: Patrick Wilson <36892066+patrickrwilson@users.noreply.github.com>

…the product template.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: operating-unit-16.0/operating-unit-16.0-product_operating_unit Translate-URL: https://translation.odoo-community.org/projects/operating-unit-16-0/operating-unit-16-0-product_operating_unit/

Currently translated at 100.0% (7 of 7 strings) Translation: operating-unit-16.0/operating-unit-16.0-product_operating_unit Translate-URL: https://translation.odoo-community.org/projects/operating-unit-16-0/operating-unit-16-0-product_operating_unit/es/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: operating-unit-16.0/operating-unit-16.0-product_operating_unit Translate-URL: https://translation.odoo-community.org/projects/operating-unit-16-0/operating-unit-16-0-product_operating_unit/

Currently translated at 14.2% (1 of 7 strings) Translation: operating-unit-16.0/operating-unit-16.0-product_operating_unit Translate-URL: https://translation.odoo-community.org/projects/operating-unit-16-0/operating-unit-16-0-product_operating_unit/ja/

This PR fixes an issue with the method operating_unit_default_get where it would return an operating unit even for a company that was not active, which would cause all sorts of issues Steps to reproduce on runboat, taking as example purchase_operating_unit: - User has a default ou belonging to Company 1 - Switch to Company 2 (make sure Company 1 is not active at all) - Try to create a Purchase Order The issue arises because the operating_unit field is pre-compiled on the PO with an Operating Unit whose company is inactive, and the onchanges cannot find or access related data.

Currently translated at 100.0% (7 of 7 strings) Translation: operating-unit-16.0/operating-unit-16.0-product_operating_unit Translate-URL: https://translation.odoo-community.org/projects/operating-unit-16-0/operating-unit-16-0-product_operating_unit/it/

ghost · 2024-07-08T19:52:46Z

@gurneyalex @yankinmax Rebased and good to go 👍

gurneyalex · 2024-07-19T10:24:48Z

/ocabot merge nobump

OCA-git-bot · 2024-07-19T10:24:54Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-668-by-gurneyalex-bump-nobump, awaiting test results.

OCA-git-bot · 2024-07-19T10:28:29Z

Congratulations, your PR was merged at 1fe5bd0. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot added this to the 17.0 milestone May 28, 2024

OCA-git-bot mentioned this pull request May 28, 2024

Migration to version 17.0 #637

Open

16 tasks

SilvioC2C reviewed Jun 4, 2024

View reviewed changes

yankinmax approved these changes Jun 11, 2024

View reviewed changes

Camille0907 approved these changes Jun 17, 2024

View reviewed changes

OCA-git-bot added the approved label Jun 17, 2024

mara1 and others added 19 commits July 8, 2024 21:51

New module product_operating_unit to introduce the operating unit to …

1fd26e8

…the product template.

[ADD] Added a product_operating_unit v12

a1caed9

[FIX] Uncomment rule

f26dc1e

[FIX] Default Get + Show OU on Small Form

a434a0d

[IMP] Create Product Access Error

bf6e832

Update product_operating_unit/views/product_template_view.xml

e24c5a1

Co-Authored-By: Patrick Wilson <36892066+patrickrwilson@users.noreply.github.com>

[IMP] Improved code

12e8d21

New module product_operating_unit to introduce the operating unit to …

b5372eb

…the product template.

[ADD] Added a product_operating_unit v12

e756736

[FIX] Uncomment rule

f2509bc

[FIX] Default Get + Show OU on Small Form

8854e69

[IMP] Create Product Access Error

8b6314a

[IMP] Improved code

83c721e

[IMP] product_operating_unit

0300e38

Added translation using Weblate (Portuguese)

0953ede

[IMP] product_operating_unit: black, isort, prettier

870e5e1

[MIG] product_operating_unit: Migration to 14.0

bd78270

[FIX] Fixed OU constrains with product

8738f63

[MIG] product_operating_unit: Migration to 16.0

5b69cab

oca-ci and others added 15 commits July 8, 2024 21:51

[UPD] Update product_operating_unit.pot

178057a

[UPD] README.rst

cb1ae06

Added translation using Weblate (Spanish)

963eae6

[UPD] README.rst

41f4f30

Added translation using Weblate (Japanese)

1066f89

[BOT] post-merge updates

d84b1a6

Added translation using Weblate (Italian)

3616878

[IMP] product_operating_unit: pre-commit execution

aec3181

[MIG] product_operating_unit: Migration to 17.0

f589b76

OCA-git-bot added the bot is merging ⏳ label Jul 19, 2024

OCA-git-bot merged commit 0f07bf5 into OCA:17.0 Jul 19, 2024

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jul 19, 2024

		if self.categ_id and self.categ_id.operating_unit_ids:
		return [(6, 0, self.categ_id.operating_unit_ids.ids)]

Uh oh!

[MIG] product_operating_unit: Migration to 17.0 #668

[MIG] product_operating_unit: Migration to 17.0 #668

Uh oh!

Conversation

ghost commented May 28, 2024 • edited by gurneyalex Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AaronHForgeFlow commented May 28, 2024

Uh oh!

SilvioC2C left a comment

Choose a reason for hiding this comment

Uh oh!

SilvioC2C Jun 4, 2024

Choose a reason for hiding this comment

Uh oh!

yankinmax Jun 8, 2024

Choose a reason for hiding this comment

Uh oh!

ghost Jun 11, 2024 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SilvioC2C Jun 4, 2024

Choose a reason for hiding this comment

Uh oh!

ghost Jun 11, 2024

Choose a reason for hiding this comment

Uh oh!

SilvioC2C Jun 4, 2024

Choose a reason for hiding this comment

Uh oh!

ghost Jun 11, 2024

Choose a reason for hiding this comment

Uh oh!

yankinmax commented Jun 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yankinmax commented Jun 11, 2024

Uh oh!

Camille0907 left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

ghost Jun 24, 2024

Choose a reason for hiding this comment

Uh oh!

gurneyalex commented Jul 3, 2024

Uh oh!

yankinmax commented Jul 8, 2024 • edited by gurneyalex Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jul 8, 2024

Uh oh!

gurneyalex commented Jul 19, 2024

Uh oh!

OCA-git-bot commented Jul 19, 2024

Uh oh!

OCA-git-bot commented Jul 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

ghost commented May 28, 2024 •

edited by gurneyalex

Loading

ghost Jun 11, 2024 •

edited by ghost

Loading

yankinmax commented Jun 8, 2024 •

edited

Loading

yankinmax commented Jul 8, 2024 •

edited by gurneyalex

Loading