Skip to content

Conversation

@vrenaville
Copy link

@vrenaville vrenaville commented Jun 24, 2020

  • Purpose
    Force attachment for async import as 'binary'
    For unknown reason, possibly a "default_type" key in context, the attachment
    has been created with a value "product" for the type, which fails with an
    exception because this type is invalid.
    Even if the root cause is not known yet, forcing the type as binary is more
    defensive and always the value we expect.

@guewen
Copy link
Member

guewen commented Jun 24, 2020

Do you have more details?

@guewen
Copy link
Member

guewen commented Jun 26, 2020

Could you amend the commit message to put this description?

Force attachment for async import as 'binary'

For unknown reason, possibly a "default_type" key in context, the attachment
has been created with a value "product" for the type, which fails with an
exception because this type is invalid.

Even if the root cause is not known yet, forcing the type as binary is more
defensive and always the value we expect.

@simahawk
Copy link
Contributor

@vrenaville ping :)

@guewen
Copy link
Member

guewen commented May 17, 2021

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 11.0-ocabot-merge-pr-242-by-guewen-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ead40a4 into OCA:11.0 May 17, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b2932fe. Thanks a lot for contributing to OCA. ❤️

@giarve
Copy link

giarve commented Jul 10, 2022

Can this be cherry-picked to 14.0 branch?

Same error, same solution (tested).

Double quotes " are used instead of single quotes ' in 14.0, do you want me to create a PR for this or cherry-picking it is enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants