[14.0] base_import_async: add a dedicated channel #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simahawk
reviewed
Aug 1, 2022
| <record id="job_function_base_import_import_split_file" model="queue.job.function"> | ||
| <field name="model_id" ref="base_import.model_base_import_import" /> | ||
| <field name="method">_split_file</field> | ||
| <field name="channel_id" ref="channel_base_import" /> |
Contributor
There was a problem hiding this comment.
to make these changes effective we need a migration step IMO
Member
There was a problem hiding this comment.
It can be changed by users, could be good to have a migration (only if no other channel than root was configured manually), but is not strictly required IMO
guewen
approved these changes
Aug 24, 2022
sbidoul
approved these changes
Oct 18, 2022
Contributor
|
This PR has the |
lmignon
approved these changes
Nov 22, 2022
Contributor
|
/ocabot merge patch |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 8a43fe6. Thanks a lot for contributing to OCA. ❤️ |
This was referenced Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we can configure the size of the channel.
We experienced a lot of locks and concurrent update issues on a table because tens of jobs were running in parallel (
rootis set with a high value).