[16.0] [MIG] queue_job and test_queue_job

[baimont]

#459

[hugosantosred]

Thanks for the migration. Apart from that comment looks good to me

[guewen]

Hi, thanks for your work!
Could you migrate test_queue_job as well?
If it is not migrated at the same time, we have no way to tell if queue_job behaves as expected as most of the tests are there.

[baimont]

Hi, thanks for your work! Could you migrate test_queue_job as well? If it is not migrated at the same time, we have no way to tell if queue_job behaves as expected as most of the tests are there.

Hi @guewen, done

[guewen]

@baimont can't we replace the import with from unittest import mock?

[baimont]

@guewen yes this is better. I adapted the commit

[guewen]

Great! Many thanks!

[guewen]

/ocabot merge nobump

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-460-by-guewen-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at e7c272d. Thanks a lot for contributing to OCA. ❤️

[guewen]

@baimont did you check if jobs were executed? I'm testing locally (I have been enthusiastic about merging 😅), but jobs aren't executed. Now, I may have botched my install

[baimont]

@baimont did you check if jobs were executed? I'm testing locally (I have been enthusiastic about merging 😅), but jobs aren't executed. Now, I may have botched my install

Ahahaha I always execute them myself with pytest-odoo before pushing any change, so yes

[guewen]

That's nice, but sorry I speak about jobs ;)

[baimont]

That's nice, but sorry I speak about jobs ;)

Sorry I misread.
I verified through the web client with https://github.com/acsone/queue/blob/6caca1aa057bc38706af3f92c33ee51c5c6c2c7f/queue_job/controllers/main.py#L110 but not sure that's enough.

[okuryan]

@pedrobaeza could you, please, publish this repo on odoo app store?

[pedrobaeza]

That should be @dreispt or @simahawk if I don't remember bad.

[okuryan]

@dreispt , @simahawk could you, please, publish queue_job to odoo app store?

[sbidoul]

@baimont could you also look for commits in 14.0 that where not in the 15.0 branch? The oca-port tool may help for that.

For instance #443 is missing, it seems.

[baimont]

@baimont could you also look for commits in 14.0 that where not in the 15.0 branch? The oca-port tool may help for that.

For instance #443 is missing, it seems.

this pr is merged so i guess this has to be done in a new pr

[dreispt]

@okuryan @pedrobaeza This repo is already published in Odoo Apps.
See for example: https://apps.odoo.com/apps/modules/15.0/queue_job/

[pedrobaeza]

@dreispt you have to publish each branch of each repo...

[okuryan]

@dreispt please, let me know when it is published for 16.0 ...

[okuryan]

@pedrobaeza are their any ways to reach person responsible for publishing? Or maybe how I can help to speed up publishing process?

[pedrobaeza]

Sorry, I can't say, as I'm not on OCA board, and don't know other OCA apps store managers.

[dreispt]

I tried again and we can now publish 16.0 branches,
It was done for the Queue repo, and this module is now available:
https://apps.odoo.com/apps/modules/16.0/queue_job/

[okuryan]

@dreispt yes, I had to write to Odoo support for this and push them through our account manager. They had bug on Odoo app store not allowing to publish Odoo 16

[baimont]

@baimont could you also look for commits in 14.0 that where not in the 15.0 branch? The oca-port tool may help for that.

For instance #443 is missing, it seems.

I did a fw port of #443 here : #470
And then I saw this : #453

[sbidoul]

@baimont I think I meant #433, actually. Sorry for the confusion.