-
-
Notifications
You must be signed in to change notification settings - Fork 536
[14.0] revert #387 #466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0] revert #387 #466
Conversation
|
Hi @guewen, |
acsonefho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That make sense
guewen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh thanks!
|
But the problem about having several allowed companies in the context still remains, isn't it? |
Which problem exactly? |
|
That the method that is executed in the job doesn't have the expected main company / allowed companies. |
|
Doing |
|
And why a separate module? |
For backward compatibility. In 16.0 it becomes the default. See #432 (comment) and the many comments before and in linked issues and PRs for context :) |
|
Well, OK, let's have such module in mind in multi-company environments... /ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 419ada0. Thanks a lot for contributing to OCA. ❤️ |
Revert #387 which should not have been merged, and update test to illustrate the proper way to pass with_company to jobs.