Skip to content

Conversation

@facusapienza21
Copy link
Member

No description provided.

@facusapienza21 facusapienza21 self-assigned this Oct 31, 2025
@facusapienza21 facusapienza21 added the Companion PR This PR is attached to another PR in a higher hierarchy library label Oct 31, 2025
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 6.45161% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.26%. Comparing base (0af1f7d) to head (5a62261).

Files with missing lines Patch % Lines
src/models/solutions/halfar.jl 9.52% 19 Missing ⚠️
src/models/iceflow/iceflow_utils.jl 0.00% 6 Missing ⚠️
src/models/iceflow/SIA2D/SIA2D_utils.jl 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
- Coverage   72.12%   69.26%   -2.87%     
==========================================
  Files          12       12              
  Lines         696      719      +23     
==========================================
- Hits          502      498       -4     
- Misses        194      221      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@albangossard albangossard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we merge this?

@facusapienza21 facusapienza21 marked this pull request as ready for review November 5, 2025 22:18
@facusapienza21
Copy link
Member Author

After the other PR is approved, yes! We should merge the two of them together (although it does not make any harm if we merge this before!)

@albangossard albangossard added the CI needs new release The CI needs a new release of at least one of the dependencies label Nov 18, 2025
@facusapienza21 facusapienza21 merged commit d06d45c into main Nov 19, 2025
4 checks passed
@albangossard albangossard deleted the InterpolationCache branch November 19, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI needs new release The CI needs a new release of at least one of the dependencies Companion PR This PR is attached to another PR in a higher hierarchy library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants