Skip to content

Conversation

@facusapienza21
Copy link
Member

@facusapienza21 facusapienza21 commented Nov 11, 2025

Addresses #126

To do:

  • Update documentation

Companion PRs:

@facusapienza21
Copy link
Member Author

This is not an urgent feature, but I would like to think a few items regarding how to design a law for this. Right now, we don't have a realistic sliding law implemented in ODINN. Furthermore, I think we also need to think a bit about having a cache per "physical component" or per coeffient. For me, it does not have much sense to have A and n independent of each other (they are not!!! You will never fit a regressor to just one of them, always the two of them or none), just as it is the same with p, q, and C for the sliding.

@JordiBolibar
Copy link
Member

Great initiative! I think we should progressively implement all the classical sliding laws to have them for comparison and for scientific comparison.

A little bit like having different temperature index models and varieties in Muninn.jl.

@facusapienza21 facusapienza21 marked this pull request as ready for review November 17, 2025 21:17
printstyled(io, " C: ";color=colorC); print(io, model.C)
printstyled(io, " n: ";color=colorn); print(io, model.n)
printstyled(io, " p: ";color=colorp); print(io, model.p)
printstyled(io, " q: ";color=colorq); print(io, model.q)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update the formulae above between elseif model.Y_is_provided and these printstyled lines.

@albangossard albangossard added the CI needs new release The CI needs a new release of at least one of the dependencies label Nov 18, 2025
@albangossard albangossard removed the CI needs new release The CI needs a new release of at least one of the dependencies label Nov 21, 2025
@albangossard albangossard merged commit d145f6a into main Nov 21, 2025
5 checks passed
@albangossard albangossard deleted the WeertmanSlidingLaw branch November 21, 2025 09:17
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 38.23529% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.75%. Comparing base (9b17cf7) to head (d1c7eee).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
src/models/iceflow/SIA2D/SIA2D.jl 28.12% 23 Missing ⚠️
src/models/iceflow/SIA2D/SIA2D_utils.jl 47.22% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   69.45%   68.75%   -0.70%     
==========================================
  Files          12       12              
  Lines         717      749      +32     
==========================================
+ Hits          498      515      +17     
- Misses        219      234      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants