-
Notifications
You must be signed in to change notification settings - Fork 5
Implement Weertman Sliding Law #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is not an urgent feature, but I would like to think a few items regarding how to design a law for this. Right now, we don't have a realistic sliding law implemented in ODINN. Furthermore, I think we also need to think a bit about having a cache per "physical component" or per coeffient. For me, it does not have much sense to have |
|
Great initiative! I think we should progressively implement all the classical sliding laws to have them for comparison and for scientific comparison. A little bit like having different temperature index models and varieties in |
| printstyled(io, " C: ";color=colorC); print(io, model.C) | ||
| printstyled(io, " n: ";color=colorn); print(io, model.n) | ||
| printstyled(io, " p: ";color=colorp); print(io, model.p) | ||
| printstyled(io, " q: ";color=colorq); print(io, model.q) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to update the formulae above between elseif model.Y_is_provided and these printstyled lines.
Update `surface_V` functions to match Weertman sliding laws
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
- Coverage 69.45% 68.75% -0.70%
==========================================
Files 12 12
Lines 717 749 +32
==========================================
+ Hits 498 515 +17
- Misses 219 234 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Addresses #126
To do:
Companion PRs: