DynamicProperties property for open type entity not wrapped with ContainerProperty attribute

[stanb]

Describe the bug

I have service with open type entity:

    public class ResultObject
    {
        public string Id { get; set; } = string.Empty;
        public IDictionary<string, object> DynamicProperties { get; set; } = new Dictionary<string, object>();
    }

Metadata:

      <EntityType Name="ResultObject" OpenType="true">
        <Key>
          <PropertyRef Name="Id" />
        </Key>
        <Property Name="Id" Type="Edm.String" Nullable="false" />
      </EntityType>

ODataConnectedService generated class:

    [global::Microsoft.OData.Client.Key("Id")]
    [global::Microsoft.OData.Client.OriginalNameAttribute("ResultObject")]
    public partial class ResultObject : global::Microsoft.OData.Client.BaseEntityType
    {
        /// <summary>
        /// Create a new ResultObject object.
        /// </summary>
        /// <param name="ID">Initial value of Id.</param>
        [global::System.CodeDom.Compiler.GeneratedCodeAttribute("Microsoft.OData.Client.Design.T4", "#VersionNumber#")]
        public static ResultObject CreateResultObject(string ID)
        {
            ResultObject resultObject = new ResultObject();
            resultObject.Id = ID;
            return resultObject;
        }
        /// <summary>
        /// There are no comments for Property Id in the schema.
        /// </summary>
        [global::System.CodeDom.Compiler.GeneratedCodeAttribute("Microsoft.OData.Client.Design.T4", "#VersionNumber#")]

        [global::Microsoft.OData.Client.OriginalNameAttribute("Id")]
        [global::System.ComponentModel.DataAnnotations.RequiredAttribute(ErrorMessage = "Id is required.")]
        public virtual string Id
        {
            get
            {
                return this._Id;
            }
            set
            {
                this.OnIdChanging(value);
                this._Id = value;
                this.OnIdChanged();
            }
        }
        [global::System.CodeDom.Compiler.GeneratedCodeAttribute("Microsoft.OData.Client.Design.T4", "#VersionNumber#")]
        private string _Id;
        partial void OnIdChanging(string value);
        partial void OnIdChanged();
        /// <summary>
        /// There are no comments for Property DynamicProperties in the schema.
        /// </summary>
        [global::System.CodeDom.Compiler.GeneratedCodeAttribute("Microsoft.OData.Client.Design.T4", "#VersionNumber#")]

        [global::Microsoft.OData.Client.OriginalNameAttribute("DynamicProperties")]
        public virtual global::System.Collections.Generic.IDictionary<string, object> DynamicProperties
        {
            get
            {
                return this._DynamicProperties;
            }
            set
            {
                this.OnDynamicPropertiesChanging(value);
                this._DynamicProperties = value;
                this.OnDynamicPropertiesChanged();
            }
        }
        [global::System.CodeDom.Compiler.GeneratedCodeAttribute("Microsoft.OData.Client.Design.T4", "#VersionNumber#")]
        private global::System.Collections.Generic.IDictionary<string, object> _DynamicProperties = new global::System.Collections.Generic.Dictionary<string, object>();
        partial void OnDynamicPropertiesChanging(global::System.Collections.Generic.IDictionary<string, object> value);
        partial void OnDynamicPropertiesChanged();
    }

DynamicProperties property on generated class missing [ContainerProperty] attribute.

Version of the Project affected

ODataConnectedService v1.0.2.0
VisualStudio Version v17.8.7
Microsoft.Odata.Client v7.20.0

To Reproduce

Create or update connected service

Expected behavior

DynamicProperties property should have [ContainerPropertyAttribute] attribute

Actual behavior

DynamicProperties property does not have [ContainerPropertyAttribute] attribute

[stanb]

ODataConnectedService/src/ODataConnectedService.Shared/ConnectedServiceFileHandler.cs

Lines 74 to 93 in 46241bb

	public bool EmitContainerPropertyAttribute()
	{
	var vsProject = this.Project.Object as VSProject;
	if (vsProject != null)
	{
	foreach (Reference reference in vsProject.References)
	{
	if (reference.SourceProject == null)
	{
	// Assembly reference (For project reference, SourceProject != null)
	if (reference.Name.Equals("Microsoft.OData.Client", StringComparison.Ordinal) && string.Compare(reference.Version, "7.6.4.0", StringComparison.Ordinal) > 0)
	{
	return true;
	}
	}
	}
	}
	return false;
	}

Any idea why it bound to specific version of Microsoft.OData.Client?
ODataCliFileHandler.EmitContainerPropertyAttribute() returns true unconditionally.

ODataConnectedService/src/Microsoft.OData.Cli/ODataCliFileHandler.cs

Lines 93 to 96 in 46241bb

	public bool EmitContainerPropertyAttribute()
	{
	return true;
	}

[gathogojr]

Fixed by #381

[stanb]

Do you have a plan on releasing a new version of VS extension? We need this fix.

[gathogojr]

Hi @stanb. We're almost here. We are finalizing on this pull request #388, and then merge the version bump pull request #387, then do the release.