Merged
Conversation
Closed
gathogojr
requested review from
ElizabethOkerio,
KenitoInc,
habbes and
marabooy
KenitoInc
reviewed
Sep 1, 2022
Contributor
KenitoInc
left a comment
KenitoInc
left a comment
There was a problem hiding this comment.
Minor changes requested.
habbes
reviewed
Sep 1, 2022
KenitoInc
approved these changes
Sep 5, 2022
ElizabethOkerio
approved these changes
Sep 7, 2022
Nthemba
force-pushed
the
Improve_metadata_Uri_handling
branch
from
d0beb43 to
d9229ca
Compare
gathogojr
reviewed
Sep 12, 2022
gathogojr
reviewed
Sep 12, 2022
gathogojr
reviewed
Sep 12, 2022
gathogojr
reviewed
Sep 12, 2022
gathogojr
reviewed
Sep 12, 2022
gathogojr
reviewed
Sep 12, 2022
gathogojr
reviewed
Sep 12, 2022
gathogojr
reviewed
Sep 12, 2022
gathogojr
reviewed
Sep 12, 2022
gathogojr
reviewed
Sep 12, 2022
gathogojr
reviewed
Sep 12, 2022
gathogojr
reviewed
Sep 12, 2022
Co-authored-by: John Gathogo <john.gathogo@gmail.com>
… metadata temp file
gathogojr
reviewed
Sep 16, 2022
gathogojr
reviewed
Sep 16, 2022
gathogojr
reviewed
Sep 16, 2022
gathogojr
reviewed
Sep 16, 2022
gathogojr
reviewed
Sep 16, 2022
gathogojr
reviewed
Sep 16, 2022
| <PackageReference Include="Microsoft.OData.Edm"> | ||
| <Version>7.6.3</Version> | ||
| </PackageReference> | ||
| <PackageReference Include="Microsoft.VisualStudio.SDK" Version="17.2.32505.173" ExcludeAssets="runtime"> |
Contributor
There was a problem hiding this comment.
Are the changes in this file deliberate or inadvertent?
Contributor
Author
There was a problem hiding this comment.
They are not deliberate. Let me investigate the source
gathogojr
reviewed
Sep 16, 2022
Co-authored-by: John Gathogo <john.gathogo@gmail.com>
gathogojr
approved these changes
Sep 27, 2022
This was referenced Sep 27, 2022
Closed
DavidRobinsonDk
pushed a commit
to Consit/ODataConnectedService
that referenced
this pull request
Jan 24, 2023
* Improve handling of URIs Co-authored-by: June Ngei <junengei@microsoft.com> Co-authored-by: John Gathogo <john.gathogo@gmail.com>
|
Hello, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #48
This PR fixes the issue #48
and is an add on to a contributor's (https://github.com/dr-consit) PR #237
It ensures the OData Endpoint URI does not get distorted when the URI includes query and fragment segments.
Before fix
A URI like 'http://localhost:5000/odata/$metadata?api-version=1.0' would have $metadata appended to the end of the URI which would make the OData service inaccessible.
After fix
$metadata, query and fragment segments maintain the correct position and order.
Fix for issue #272
There was a method for getting the metadata version but it was in the OData Connected Service project. While working on odata-cliI had created a method for getting the metadata version in the core project library. I have replaced the method that I had created in the core project with the method that was in the OData Connected Service project as it takes care of Custom HttpHeaders and Web Proxies.
It fixes this issue #272