-
Notifications
You must be signed in to change notification settings - Fork 51
Add command-line option for ConnectedService.json file #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gathogojr
merged 42 commits into
OData:master
from
gregwinterstein:fix/338-odata-cli-ConnectedService.json
Apr 3, 2024
Merged
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
0594ce2
Add command-line option for ConnectedService.json file
gregwinterstein 82745f3
Make method names consistent
gregwinterstein 2d8b6e3
Fix null reference exception
gregwinterstein e78d42b
Correct capitalization of JSON
gregwinterstein de602e2
Move CliUserSettings into Microsoft.OData.CodeGen and refactor UserSe…
gregwinterstein 518b66a
Remove unnecessary methods per comments
gregwinterstein 31b8068
Decrease indentation as requested
gregwinterstein cdcbb4c
Call base class constructor
gregwinterstein 67fee95
Refactor GetServiceConfiguration() to reduce indentation and throw an…
gregwinterstein 1e84a0c
Correct logic error
gregwinterstein d54dca2
Rename UserSettings to ConnectedServiceUserSettings
gregwinterstein c188a7b
Rename CliUserSettings to UserSettings
gregwinterstein 52e532a
Refactor GenerateCommand to avoid calling ReadConfigFile with a null …
gregwinterstein c89c170
Update for changes introduced with pull request #364 (fix CLI exclusi…
gregwinterstein d81e034
Clean up after rebase
gregwinterstein 0dcf4f0
Revert class name change per comments in pull request
gregwinterstein cc8724d
Revert class name change per comments in pull request
gregwinterstein e94a640
Fix XML comments according to comments in pull request
gregwinterstein 1816eb1
Rename CliConnectedServiceJsonFileData per pull request comments
gregwinterstein 0e65837
Rename CliConnectedServiceJsonFileData per pull request comments
gregwinterstein 9f47904
Use count property instead of .Any() as suggested in pull request com…
gregwinterstein 08a964f
Correct logic to allow command-line options to override config file
gregwinterstein bdb6af1
Correct string split options as suggested by pull request comments
gregwinterstein 4f7c510
Improve variable name and simplify assignment per comments in pull re…
gregwinterstein 45bf8e5
Simplify connected-service-file option name to config-file as suggest…
gregwinterstein a28a44a
Attempt to clarify optional/override behavior of metadata-uri in conj…
gregwinterstein 631e7e5
Update summary comments to suggestions made in pull request comments
gregwinterstein 08e4d37
Set boolean defaults to null so that option override logic works prop…
gregwinterstein 380dae5
Comment public properies as requested in pull request comments
gregwinterstein 8a04c25
Post-rebase cleanup
gregwinterstein a165630
Update src/Microsoft.OData.CodeGen/Models/BaseUserSettings.cs per @ga…
gregwinterstein a6b14e0
Update src/Microsoft.OData.Cli/GenerateCommand.cs per @gathogojr
gregwinterstein e84942a
Update src/Microsoft.OData.Cli/GenerateCommand.cs per @gathogojr
gregwinterstein 6f0757b
Update src/Microsoft.OData.Cli/GenerateCommand.cs per @gathogojr
gregwinterstein 1004c84
Update src/Microsoft.OData.Cli/GenerateCommand.cs
gregwinterstein efa0b1a
Update src/Microsoft.OData.Cli/GenerateCommand.cs
gregwinterstein 818d62f
Update src/Microsoft.OData.Cli/GenerateCommand.cs
gregwinterstein e0c417f
Update src/Microsoft.OData.Cli/GenerateCommand.cs
gregwinterstein 46da013
Fix variable name typo post-rebase
gregwinterstein 96ae9ee
Correct invalid code reference to ConnectedServiceFileData
gregwinterstein 2e68045
Update exceptions per @gathogojr
gregwinterstein 563602b
Correct exception thrown
gregwinterstein File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
src/Microsoft.OData.Cli/Models/ConnectedServiceFileData.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| //----------------------------------------------------------------------------- | ||
| // <copyright file="ConnectedServiceFileData.cs" company=".NET Foundation"> | ||
| // Copyright (c) .NET Foundation and Contributors. All rights reserved. | ||
| // See License.txt in the project root for license information. | ||
| // </copyright> | ||
| //---------------------------------------------------------------------------- | ||
|
|
||
| using Microsoft.OData.CodeGen.Models; | ||
|
|
||
| namespace Microsoft.OData.Cli.Models | ||
| { | ||
| /// <summary> | ||
| /// Represents OData Connected Service config file | ||
| /// </summary> | ||
| public class ConnectedServiceFileData | ||
| { | ||
| /// <summary> | ||
| /// Gets or sets the unique Provider ID for the provider/handler. This is used to match a provider with its handlers. | ||
| /// </summary> | ||
| public string ProviderId { get; set; } | ||
|
gathogojr marked this conversation as resolved.
|
||
|
|
||
| /// <summary> | ||
| /// Gets or sets the OData Connected Service user settings extracted from ConnectedService.json. | ||
| /// </summary> | ||
| public BaseUserSettings ExtendedData { get; set; } | ||
|
gathogojr marked this conversation as resolved.
|
||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.